Thanks again for your comments Aled. I neglected to mention in my original post that these pages were significantly inspired by the equivalent page on the jclouds site.
On 10 June 2014 09:28, Aled Sage <[email protected]> wrote: > * https://people.apache.org/~richard/community/how-to-contribute.html: > o "ready to be merged once it gets at lease one +1 from a reviewer" > This should be "from a committer" I presume? > o "It is also a good idea to squash all the commits into a single > one, since this will allow us to generate a clean patch and > merge it properly" > Wording feels too strong, I think. If it is a series of logical > steps (that don't justify separate PRs) then separate commits > are fine. > Could reword to "consider squashing all the commits into a > single one where appropriate, since..." > Also, committers won't be generating patches I presume - the > committer proposal is to do `git merge pull/github/1234; git > push apache master`. Thanks Aled - I have reworded to: "A pull request is considered ready to be merged once it gets at lease one +1 from a committer. Once all the changes have been completed and the pull request is accepted, you may be asked to rebase it against the latest code. You may also wish to squash some commits together and make other history revisions, to leave the commit history clean and easily understood." Richard.
