Thanks Justin.  Good idea to include versions; added to that PR:

https://github.com/ahgittin/incubator-brooklyn/commit/28d354f57e0c075213670f9c5b6e7fd5c8a031a0

Best
Alex


On 29/09/2015 06:18, Justin Mclean wrote:
HI,

You are right about Spry Media IP -- I can find no indication that the IP of plugins is properly granted. Same for the inclusion of slideto in Swagger. They are all very small so I have essentially rewritten them giving credit to the original in our code -- I think this means we are cleaner from an IP perspective as the copyright and license now lie with us but appreciate any feedback you have.

That sounds like a good solution to me. You may want to note the versions of the included software as licenses can change over time.

With requirejs/text.js both are subprojects of RequireJS so I label our dependency as on the project with explicit reference to the both the files require.js and text.js, coming from http://requirejs.org/. With r.js I treat it slightly differently as it comes from a single repo and it is a different version. Where r.js includes code fragments from other projects I've called out all the copyright holders and the license under that code was included.

Looks good.

Thanks,
Justin



--
Cloudsoft Corporation Limited, Registered in Scotland No: SC349230. Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP

This e-mail message is confidential and for use by the addressee only. If the message is received by anyone other than the addressee, please return the message to the sender by replying to it and then delete the message from your computer. Internet e-mails are not necessarily secure. Cloudsoft Corporation Limited does not accept responsibility for changes made to this message after it was sent.

Whilst all reasonable care has been taken to avoid the transmission of viruses, it is the responsibility of the recipient to ensure that the onward transmission, opening or use of this message and any attachments will not adversely affect its systems or data. No responsibility is accepted by Cloudsoft Corporation Limited in this regard and the recipient should carry out such virus and other checks as it considers appropriate.

Reply via email to