Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/962#discussion_r43097257
--- Diff: core/src/main/java/org/apache/brooklyn/util/core/osgi/Osgis.java
---
@@ -623,97 +425,4 @@ public static boolean isExtensionBundle(Bundle bundle)
{
EXTENSION_PROTOCOL.equals(Urls.getProtocol(location));
}
- /** Takes a string which might be of the form "symbolic-name" or
"symbolic-name:version" (or something else entirely)
- * and returns a VersionedName. The versionedName.getVersion() will be
null if if there was no version in the input
- * (or returning {@link Maybe#absent()} if not valid, with a suitable
error message). */
- public static Maybe<VersionedName> parseOsgiIdentifier(String
symbolicNameOptionalWithVersion) {
- if (Strings.isBlank(symbolicNameOptionalWithVersion))
- return Maybe.absent("OSGi identifier is blank");
-
- String[] parts = symbolicNameOptionalWithVersion.split(":");
- if (parts.length>2)
- return Maybe.absent("OSGi identifier has too many parts; max
one ':' symbol");
-
- Version v = null;
- if (parts.length == 2) {
- try {
- v = Version.parseVersion(parts[1]);
- } catch (IllegalArgumentException e) {
- return Maybe.absent("OSGi identifier has invalid version
string ("+e.getMessage()+")");
- }
- }
-
- return Maybe.of(new VersionedName(parts[0], v));
- }
-
- /**
- * The class is not used, staying for future reference.
- * Remove after OSGi transition is completed.
- */
- public static class ManifestHelper {
--- End diff --
keep for compatibility, but deprecated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
