Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/962#issuecomment-151429132
great set of changes to add karaf!
lots of quite minor comments but ideally they should have been addressed
before merging. we don't like to make master backwards incompatible without a
deprecation cycle. and in this case i think it could have been avoided.
@CMoH is it going to be possible to address these comments *and* fix the
issue @neykov refers to today? if not i suggest we revert until they can be
addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
