Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/962#discussion_r43098323
--- Diff:
utils/rt-osgi/src/test/java/org/apache/brooklyn/util/osgi/OsgisTest.java ---
@@ -30,12 +28,12 @@
@Test
public void testParseOsgiIdentifier() throws Exception {
- assertEquals(Osgis.parseOsgiIdentifier("a.b").get(), new
VersionedName("a.b", null));
- assertEquals(Osgis.parseOsgiIdentifier("a.b:0.1.2").get(), new
VersionedName("a.b", Version.parseVersion("0.1.2")));
-
assertEquals(Osgis.parseOsgiIdentifier("a.b:0.0.0.SNAPSHOT").get(), new
VersionedName("a.b", Version.parseVersion("0.0.0.SNAPSHOT")));
-
assertFalse(Osgis.parseOsgiIdentifier("a.b:0.notanumber.2").isPresent()); //
invalid version
-
assertFalse(Osgis.parseOsgiIdentifier("a.b:0.1.2:3.4.5").isPresent()); //
too many colons
-
assertFalse(Osgis.parseOsgiIdentifier("a.b:0.0.0_SNAPSHOT").isPresent()); //
invalid version
- assertFalse(Osgis.parseOsgiIdentifier("").isPresent());
+ assertEquals(OsgiUtils.parseOsgiIdentifier("a.b").get(), new
VersionedName("a.b", null));
--- End diff --
so now we have both `Osgis` and `OsgiUtils`? that's confusing. let's just
have one, or give them more detailed names. (but remember we want to preserve
backwards compatibility.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
