Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43649604
  
    --- Diff: parent/pom.xml ---
    @@ -208,9 +208,9 @@
                     <version>${swagger.version}</version>
                 </dependency>
                 <dependency>
    -                <groupId>org.eclipse.jetty.orbit</groupId>
    -                <artifactId>javax.servlet</artifactId>
    -                <version>${jetty-orbit-javax-servlet.version}</version>
    +                <groupId>javax.servlet</groupId>
    +                <artifactId>javax.servlet-api</artifactId>
    +                <version>${javax-servlet.version}</version>
    --- End diff --
    
    You left the dependency only in the `dependencyManagement` section in the 
parent pom, which doesn't actually pull it as a dependency, just declares which 
version to use in case anyone needs it. If classes from it are still directly 
referenced, then put it explicitly in the `dependencies` sections in modules 
that need it. It works now because it's a transitive dependency of jetty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to