Github user CMoH commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43769972
--- Diff:
usage/launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynWebServerTest.java
---
@@ -146,11 +146,13 @@ public void verifyHttpsFromConfig() throws Exception {
@Test
public void verifyHttpsCiphers() throws Exception {
brooklynProperties.put(BrooklynWebConfig.HTTPS_REQUIRED, true);
- brooklynProperties.put(BrooklynWebConfig.TRANSPORT_PROTOCOLS,
"XXX");
- brooklynProperties.put(BrooklynWebConfig.TRANSPORT_CIPHERS, "XXX");
--- End diff --
I must confess I did not understand the intention of this test. Jetty9 is
throwing `java.net.SocketException`. Shall we add that to the list? Or just
replace the list with this exception?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
