Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43863597
  
    --- Diff: parent/pom.xml ---
    @@ -208,9 +208,9 @@
                     <version>${swagger.version}</version>
                 </dependency>
                 <dependency>
    -                <groupId>org.eclipse.jetty.orbit</groupId>
    -                <artifactId>javax.servlet</artifactId>
    -                <version>${jetty-orbit-javax-servlet.version}</version>
    +                <groupId>javax.servlet</groupId>
    +                <artifactId>javax.servlet-api</artifactId>
    +                <version>${javax-servlet.version}</version>
    --- End diff --
    
    * If Brooklyn is using classes from the package then the convention is to 
explicitly declare it as a dependency in the corresponding module(s)
    * If it's only a transitive dependency then its version shouldn't be fixed, 
unless there's a version conflict as this might lead to unexpected behaviour in 
future where another version is expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to