chenBright commented on PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1174659914

   > @chenBright 这个问题能不能通过在判断ssl_state和_ssl_session基础上解决呢?比如在DoWrite里
   > 
   > ```
   > current_ssl_session = _ssl_session
   > if (current_ssl_session == NULL) {
   >    // necessary comment
   >    return -1;
   > }
   > ...
   > butil::IOBuf::cut_multiple_into_SSL_channel(current_ssl_session, ...)
   > ```
   > 
   > 这样保证current_ssl_session不是NULL,不出core,然后写fd的时候发现对端已经关了连接就走正常错误处理的代码了。
   
   还有一个问题:https://github.com/apache/incubator-brpc/issues/658 
这个case中,当HealthCheckTask等到引用计数为2后,Connect之前,另一处rpc 
DoWrite失败,rpc结束,引用计数减一。此时,该下游节点恢复了,HealthCheckTask成功Connect,并将Socket 
Revive。此时Socket是正常的,但是没有地方持有对应的SocketId,那么这个Socket是“泄漏”了吧?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to