zchuango commented on code in PR #3409:
URL: https://github.com/apache/brpc/pull/3409#discussion_r3735915264
##########
src/brpc/controller.cpp:
##########
@@ -1611,6 +1696,10 @@ void
Controller::ReadProgressiveAttachmentBy(ProgressiveReader* r) {
__FUNCTION__));
}
add_flag(FLAGS_PROGRESSIVE_READER);
+ if (progressive_read_timeout_ms() > 0) {
+ auto reader = new ProgressiveTimeoutReader(_rpa->GetSocketId(),
_progressive_read_timeout_ms, r);
+ return _rpa->ReadProgressiveAttachmentBy(reader);
+ }
Review Comment:
Fixed. Added unit tests covering active reads, idle timeout after receiving
data, timeout before the first body part, slow user callbacks, reader error
propagation, and unsupported HTTP/2 contexts.
Validation:
All six newly added focused tests passed.
The full brpc_http_rpc_protocol_unittest suite passed (52/52).
Verified in the local Docker build environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
