zchuango commented on PR #3409: URL: https://github.com/apache/brpc/pull/3409#issuecomment-5217531297
@wwbmmm Thanks for the review. I have pushed updates addressing the remaining Copilot comments and resolved the corresponding review threads. The idle deadline is now refreshed after each successful read, timeout cleanup goes through `Socket::SetFailed()`, and the timer and reader lifetimes are coordinated to avoid unsafe callback access. The related socket ID initialization, errno registration, header dependency, examples, and tests were also updated. Validation: - All six newly added focused tests passed. - The full `brpc_http_rpc_protocol_unittest` suite passed (52/52). - Verified in the local Docker build environment. Could you please take another look when convenient? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
