PS Huge thank you to Kevin for being release manager. This has been one of our most complex releases, and I know that Kevin has put in a massive effort to get the release this far. I hope the process is over soon!
> On Mar 14, 2019, at 5:51 PM, Julian Hyde <jh...@apache.org> wrote: > > -1 due to .mvn/wrapper/maven-wrapper.jar > > maven-wrapper.jar is a binary file, and we cannot have binary files in source > distributions. (Note that ./mvnw can bootstrap just fine without it. Also > note that it is not checked into git — I guess it is created during the > release build process.) > > Everything else was fine. Checked hashes, KEYS, LICENSE, NOTICE, README; > checked that contents of tar match git; compiled and ran tests using JDK 11 > on Ubuntu linux. > > Julian > > >> On Mar 14, 2019, at 10:30 AM, Vladimir Sitnikov >> <sitnikov.vladi...@gmail.com> wrote: >> >> +1 (binding) >> >> Checksum matches, the code compiles. >> Release notes look ok. >> >> Thanks, Kevin >> >> Vladimir >
