If I was release manager for 1.18, it’s possible that I used ‘mvn’ rather than ‘./mvnw’. I don’t recall. If so, my bad, I should have updated the release instructions.
Julian On Mar 14, 2019, at 7:22 PM, Kevin Risden <kris...@apache.org> wrote: >> >> maven-wrapper.jar is a binary file, and we cannot have binary files in >> source distributions. (Note that ./mvnw can bootstrap just fine without it. >> Also note that it is not checked into git — I guess it is created during >> the release build process.) >> > > Hmmm that is interesting. ./mvnw downloads the > .mvn/wrapper/maven-wrapper.jar file. The release steps say to use ./mvnw > (ie: ./mvnw -DskipTests -Papache-release release:perform 2>&1 | tee > /tmp/perform.log) so not sure if there is something I need to do > differently or needs to be figured out to ensure the .mvn directory is not > included in the source distribution. > > Kevin Risden > > >> On Thu, Mar 14, 2019 at 8:56 PM Julian Hyde <jh...@apache.org> wrote: >> >> PS Huge thank you to Kevin for being release manager. This has been one of >> our most complex releases, and I know that Kevin has put in a massive >> effort to get the release this far. I hope the process is over soon! >> >>> On Mar 14, 2019, at 5:51 PM, Julian Hyde <jh...@apache.org> wrote: >>> >>> -1 due to .mvn/wrapper/maven-wrapper.jar >>> >>> maven-wrapper.jar is a binary file, and we cannot have binary files in >> source distributions. (Note that ./mvnw can bootstrap just fine without it. >> Also note that it is not checked into git — I guess it is created during >> the release build process.) >>> >>> Everything else was fine. Checked hashes, KEYS, LICENSE, NOTICE, README; >> checked that contents of tar match git; compiled and ran tests using JDK 11 >> on Ubuntu linux. >>> >>> Julian >>> >>> >>>> On Mar 14, 2019, at 10:30 AM, Vladimir Sitnikov < >> sitnikov.vladi...@gmail.com> wrote: >>>> >>>> +1 (binding) >>>> >>>> Checksum matches, the code compiles. >>>> Release notes look ok. >>>> >>>> Thanks, Kevin >>>> >>>> Vladimir >>> >> >>
