I also lean towards updating existing tests to JUnit5. Perhaps split it into two parts:
1. The ones that can be migrated easily (replacing annotations, minimal manual intervention) 2. Existing JUnit 4 rules / parameterized tests JUnit4 and JUnit5 can coexists and evaluated by the same engine. On Mon, Dec 2, 2019 at 5:19 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Stamatis> If we go for the bulk modifications approach why not migrating > completely to JUnit5? > > Migration to JUnit5 seems to be ok. > > I've filed a draft that updates the APIs: > https://github.com/apache/calcite/pull/1621 > It does not seem to touch too many places, and in most of the cases, it is > a mere import adjustment. > > Vladimir >
