Thanks for explaining. Those steps make sense. My question was in the spirit of “show your working”. I know that “./gradlew” will not work against RC1 if you follow the official instructions, so a possible explanation was that you were validating RC0 by accident.
Julian > On May 14, 2021, at 1:34 AM, Alessandro Solimando > <alessandro.solima...@gmail.com> wrote: > > Hi Julian, > I have copied both "gradlew" and the needed files under "gradle" directory > from the local git repository to the unpacked directory extracted from the > artifact downloaded from > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.18.0-rc1 > > Are you asking because this might tamper with the procedure to check the > source code? > > Best regards, > Alessandro > > On Wed, 12 May 2021 at 19:37, Julian Hyde <jhyde.apa...@gmail.com> wrote: > >> Alessandro, >> >> I’m curious how you were able to run “./gradlew”. That source distribution >> does not contain the Gradle wrapper. (See >> https://issues.apache.org/jira/browse/CALCITE-4575 < >> https://issues.apache.org/jira/browse/CALCITE-4575>.) >> >> Julian >> >> >>> On May 12, 2021, at 3:00 AM, Alessandro Solimando < >> alessandro.solima...@gmail.com> wrote: >>> >>> Hi, >>> >>> +1 (non-binding) after verifying the release as follows. >>> >>> 1) Checksum: OK >>> >>> 2) Signature: OK >>> >>> 3) Running tests: >>> >>> - >>> >>> “./gradlew build -Prelease -PskipSign”: OK (see JVM, OS and gradle >>> details at the bottom) >>> - >>> >>> “docker-compose run test”: OK >>> - >>> >>> Check CI on github for the commit: OK >>> >>> 4) compared archive content vs git master: OK >>> >>> $ java -version: >>> >>> openjdk version "1.8.0_265" >>> >>> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_265-b01) >>> >>> OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.265-b01, mixed mode) >>> >>> $ ./gradlew -v >>> ------------------------------------------------------------ >>> Gradle 6.8.1 >>> ------------------------------------------------------------ >>> >>> Build time: 2021-01-22 13:20:08 UTC >>> Revision: 31f14a87d93945024ab7a78de84102a3400fa5b2 >>> >>> Kotlin: 1.4.20 >>> Groovy: 2.5.12 >>> Ant: Apache Ant(TM) version 1.10.9 compiled on September 27 2020 >>> JVM: 1.8.0_265 (AdoptOpenJDK 25.265-b01) >>> OS: Mac OS X 10.15.7 x86_64 >>> >>> $ sw_vers >>> >>> ProductName: Mac OS X >>> >>> ProductVersion: 10.15.7 >>> >>> BuildVersion: 19H524 >>> >>> >>> Best regards, >>> >>> Alessandro >>> >>> On Wed, 12 May 2021 at 08:41, Julian Hyde <jh...@apache.org> wrote: >>> >>>> +1 (binding) >>>> >>>> Checked hashes & signature. Compiled & ran tests on Linux / JDK 8, JDK >>>> 11, OpenJDK 15 / Gradle 6.8.1. Checked LICENSE, NOTICE. Ran rat. >>>> Checked build instructions. Checked that contents of tar.gz match git >>>> commit (except for gradle wrapper, licenses, fonts). >>>> >>>> Thank you, Francis! >>>> >>>> Julian >>>> >>>> On Tue, May 11, 2021 at 10:01 PM Francis Chuang >>>> <francischu...@apache.org> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> I have created a build for Apache Calcite Avatica 1.18.0, release >>>>> candidate 1. >>>>> >>>>> Thanks to everyone who has contributed to this release. >>>>> >>>>> You can read the release notes here: >>>>> >>>> >> https://github.com/apache/calcite-avatica/blob/avatica-1.18.0-rc1/site/_docs/history.md >>>>> >>>>> The commit to be voted upon: >>>>> >>>> >> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=a7cfca41a32ce0c93c2ed24f70401bde9a7fe01a >>>>> >>>>> Its hash is a7cfca41a32ce0c93c2ed24f70401bde9a7fe01a >>>>> >>>>> Tag: >>>>> >>>> >> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.18.0-rc1 >>>>> >>>>> The artifacts to be voted on are located here: >>>>> >>>> >> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.18.0-rc1 >>>>> (revision 47651) >>>>> >>>>> The hashes of the artifacts are as follows: >>>>> >>>> >> c4e2055af449dc3f1af3478baec7a93d3a56975102206e37cfe5e11f89583139b86b68d858160b0f0519cd246275aa226ee47f70404d6f9e495a1c8527d9a66e >>>>> *apache-calcite-avatica-1.18.0-src.tar.gz >>>>> >>>>> A staged Maven repository is available for review at: >>>>> >>>> >> https://repository.apache.org/content/repositories/orgapachecalcite-1103/org/apache/calcite/ >>>>> >>>>> Release artifacts are signed with the following key: >>>>> https://people.apache.org/keys/committer/francischuang.asc >>>>> https://www.apache.org/dist/calcite/KEYS >>>>> >>>>> To create the jars and test Apache Calcite Avatica: "gradle build >>>>> -Prelease -PskipSign". >>>>> >>>>> If you do not have a Java/Gradle environment available, you can run the >>>>> tests using docker. To do so, install docker and docker-compose, then >>>>> run "docker-compose run test" from the root of the directory. >>>>> >>>>> Please vote on releasing this package as Apache Calcite Avatica 1.18.0. >>>>> >>>>> The vote is open for the next 72 hours and passes if a majority of at >>>>> least three +1 PMC votes are cast. >>>>> >>>>> [ ] +1 Release this package as Apache Calcite Avatica 1.18.0 >>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>>>> [ ] -1 Do not release this package because... >>>>> >>>>> >>>>> Here is my vote: >>>>> >>>>> +1 (binding) >>>>> >>>>> Francis >>>> >> >>
