+1 (non binding)

Run all tests of HerdDB, all tests are passing without any code
change. (https://github.com/diennea/herddb/pull/779)

I would like to note that previous tests of HerdDB did not pass with
1.29.0 (and we were stuck to 1.28.0). With 1.29.0 tests on Github
actions hang during some classloading of some Calcite classes

thank you Liya

Enrico

Il giorno lun 7 mar 2022 alle ore 09:20 Fan Liya
<liya.fa...@gmail.com> ha scritto:
>
> Hi Xiong,
>
> Thanks for your feedback. I will change the logs in a follow up MR.
>
> Best,
> Liya Fan
>
>
> xiong duan <nobigo...@gmail.com> 于2022年3月7日周一 15:30写道:
>
> > Hi, Liya Fan.Thanks for your work.  +1.
> > Just a little problem:
> > I noticed the Bug-fixes logs all started with Fix....I think maybe we
> > should stay the same as JIRA summary or PR commit?
> >
> > Fan Liya <liya...@apache.org> 于2022年3月7日周一 14:55写道:
> >
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.30.0, release
> > > candidate 1.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> > >
> > https://github.com/apache/calcite/blob/calcite-1.30.0-rc1/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> > >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f14cf4c32b9079984a988bbad40230aa6a59b127
> > >
> > > Its hash is f14cf4c32b9079984a988bbad40230aa6a59b127
> > >
> > > Tag:
> > > https://github.com/apache/calcite/tree/calcite-1.30.0-rc1
> > >
> > > The artifacts to be voted on are located here:
> > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc1
> > > (revision 52897)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> > >
> > 25527b5dfd3c28d4ac3c9d9a40b94dbcbce7feb17cc198ebe7c36a30c2df69a27ee5e4defab4edff1e1bc65c076bd0725bd8c378913d1d23f3d80f732e3e097f
> > > *apache-calcite-1.30.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> > >
> > https://repository.apache.org/content/repositories/orgapachecalcite-1150/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/COMMITTER_ID.asc
> > > https://www.apache.org/dist/calcite/KEYS
> > >
> > > To create the jars and test Apache Calcite: "gradle build"
> > > (requires an appropriate Gradle/JDK installation)
> > >
> > > Please vote on releasing this package as Apache Calcite 1.30.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.30.0
> > > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Best,
> > > Liya Fan
> > >
> >

Reply via email to