Hi Ruben and Julian, Thanks a lot for your feedback, I will prepare a PR addressing all the issues described above.
Best, Liya Fan Julian Hyde <jhyde.apa...@gmail.com> 于2022年3月10日周四 08:03写道： > Liya, > > I made much the same comments as Ruben regarding the release notes. > > Though we don’t usually use PRs for releases, I think it would be useful > if we had a PR in which to review the release notes. It seems better than > bike-shedding them during the actual release vote. If you agree, can you > post that PR? > > Julian > > > > On Mar 9, 2022, at 2:59 AM, Ruben Q L <rube...@gmail.com> wrote: > > > > Thanks Liya Fan for being the release manager. > > > > First of all, for the record regarding the RC itself: > > - Checksum and signature: ok > > - Gradle test: ok > > - Calcite-based application test suite: ok > > > > IMO release notes would need some adjustments: > > - Traditionally, at the beginning of the release note, before the > > "Compatibility" paragraph, there should be another paragraph describing > the > > highlights of the release (see previous releases as an example). > > - If I am not mistaken, there is a CVE to be mentioned in the release > note, > > which does not seem to be there. > > - I would suggest to keep the traditional sections (see previous > > releases): New features; Bug-fixes, API changes and minor > > enhancements; Build and test suite; Dependency version upgrade; Web site > > and documentation > > - As Xiong said, bug fixes should not begin with "Fix..."; instead, the > > commit message (or Jira title) should be used (this should be the norm > for > > all the tickets in the release note, not just the bug fixes). > > - This particular item "[CALCITE-3673] Support ListTransientTable without > > tables in the schema" is not a "New feature", but rather a "Minor > > enhancement" or "Bug fix". Its title in the release note is also > > misleading. I would suggest to keep the original Jira title / commit > > message: "ListTransientTable should not leave tables in the schema". > > - Apart from that, CALCITE-4976 mentions some modification to be made in > > howto.md. > > > > Having said that, as Stamatis mentioned, I had also noticed something > > strange on the repository while I was checking some of tickets that I had > > resolved (the fact that the commit which resolved the issue does not > belong > > to any repository any more). As Stamatis suggests, I think we should put > on > > hold the RC process until we figure out what happened and how to handle > the > > situation. > > > > Best, > > Ruben > > > > > > On Wed, Mar 9, 2022 at 10:13 AM Stamatis Zampetakis <zabe...@gmail.com> > > wrote: > > > >> Thanks for preparing the RC Liya! > >> > >> The repository seems to be in some weird state (see [1]) so I don't feel > >> comfortable getting a release out till we understand what exactly has > >> happened. > >> Let's continue the discussion under the respective thread. > >> > >> -1 (binding) > >> > >> Stamatis > >> > >> [1] https://lists.apache.org/thread/pw7q8tqn78rwq0sfxh6o2rxvwrjgjlkq > >> > >> On Mon, Mar 7, 2022 at 12:27 PM Enrico Olivelli <eolive...@gmail.com> > >> wrote: > >> > >>> +1 (non binding) > >>> > >>> Run all tests of HerdDB, all tests are passing without any code > >>> change. (https://github.com/diennea/herddb/pull/779) > >>> > >>> I would like to note that previous tests of HerdDB did not pass with > >>> 1.29.0 (and we were stuck to 1.28.0). With 1.29.0 tests on Github > >>> actions hang during some classloading of some Calcite classes > >>> > >>> thank you Liya > >>> > >>> Enrico > >>> > >>> Il giorno lun 7 mar 2022 alle ore 09:20 Fan Liya > >>> <liya.fa...@gmail.com> ha scritto: > >>>> > >>>> Hi Xiong, > >>>> > >>>> Thanks for your feedback. I will change the logs in a follow up MR. > >>>> > >>>> Best, > >>>> Liya Fan > >>>> > >>>> > >>>> xiong duan <nobigo...@gmail.com> 于2022年3月7日周一 15:30写道： > >>>> > >>>>> Hi, Liya Fan.Thanks for your work. +1. > >>>>> Just a little problem: > >>>>> I noticed the Bug-fixes logs all started with Fix....I think maybe we > >>>>> should stay the same as JIRA summary or PR commit? > >>>>> > >>>>> Fan Liya <liya...@apache.org> 于2022年3月7日周一 14:55写道： > >>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> I have created a build for Apache Calcite 1.30.0, release > >>>>>> candidate 1. > >>>>>> > >>>>>> Thanks to everyone who has contributed to this release. > >>>>>> > >>>>>> You can read the release notes here: > >>>>>> > >>>>>> > >>>>> > >>> > >> > https://github.com/apache/calcite/blob/calcite-1.30.0-rc1/site/_docs/history.md > >>>>>> > >>>>>> The commit to be voted upon: > >>>>>> > >>>>>> > >>>>> > >>> > >> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f14cf4c32b9079984a988bbad40230aa6a59b127 > >>>>>> > >>>>>> Its hash is f14cf4c32b9079984a988bbad40230aa6a59b127 > >>>>>> > >>>>>> Tag: > >>>>>> https://github.com/apache/calcite/tree/calcite-1.30.0-rc1 > >>>>>> > >>>>>> The artifacts to be voted on are located here: > >>>>>> > >>> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc1 > >>>>>> (revision 52897) > >>>>>> > >>>>>> The hashes of the artifacts are as follows: > >>>>>> > >>>>>> > >>>>> > >>> > >> > 25527b5dfd3c28d4ac3c9d9a40b94dbcbce7feb17cc198ebe7c36a30c2df69a27ee5e4defab4edff1e1bc65c076bd0725bd8c378913d1d23f3d80f732e3e097f > >>>>>> *apache-calcite-1.30.0-src.tar.gz > >>>>>> > >>>>>> A staged Maven repository is available for review at: > >>>>>> > >>>>>> > >>>>> > >>> > >> > https://repository.apache.org/content/repositories/orgapachecalcite-1150/org/apache/calcite/ > >>>>>> > >>>>>> Release artifacts are signed with the following key: > >>>>>> https://people.apache.org/keys/committer/COMMITTER_ID.asc > >>>>>> https://www.apache.org/dist/calcite/KEYS > >>>>>> > >>>>>> To create the jars and test Apache Calcite: "gradle build" > >>>>>> (requires an appropriate Gradle/JDK installation) > >>>>>> > >>>>>> Please vote on releasing this package as Apache Calcite 1.30.0. > >>>>>> > >>>>>> The vote is open for the next 72 hours and passes if a majority of > >> at > >>>>>> least three +1 PMC votes are cast. > >>>>>> > >>>>>> [ ] +1 Release this package as Apache Calcite 1.30.0 > >>>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the > >> release > >>>>>> [ ] -1 Do not release this package because... > >>>>>> > >>>>>> Here is my vote: > >>>>>> > >>>>>> +1 (binding) > >>>>>> > >>>>>> Best, > >>>>>> Liya Fan > >>>>>> > >>>>> > >>> > >> > >
