Thanks Andrei, now there is nobody to review these PRs, It's ok to change to 1.32，I think pr-2838 <https://github.com/apache/calcite/pull/2838> for CALCITE-5045 <https://issues.apache.org/jira/browse/CALCITE-5045> should be merged before 1.31, because it's simple and Yingyu Wang encountered this problem also.
Andrei Sereda <[email protected]> 于2022年6月22日周三 10:06写道： > Julian, how much time do you think is necessary to fix CALCITE-35 > regression ? > > Yanjing, I see some discussions/attempts in JIRA/github to review the PRs. > Do you think it can still be reviewed and merged before 1.31 ? > > Viliam (and Julian), thanks for fixing (and merging) CALCITE-5157 > > Dmitry (and Stamatis / Ruben), thanks for fixing (and merging) > CALCITE-5134. > As I understand CALCITE-5127 is delayed until 1.32 ? > > > > On Tue, Jun 21, 2022 at 2:57 AM Julian Hyde <[email protected]> > wrote: > > > I agree that it’s a regression, and caused by my CALCITE-35 change. I’ve > > assigned the bug to myself. I’m not sure I have time to fix it this week, > > so we can back out my change if necessary to get the release out on > > schedule. If someone else can fix it I would be grateful. > > > > > > > On Jun 19, 2022, at 2:26 AM, Vova Vysotskyi <[email protected]> > > wrote: > > > > > > Hello, > > > > > > I have found the following regression while verifying the new release > to > > work with Apache Drill: > https://issues.apache.org/jira/browse/CALCITE-5194 > > . > > > This issue appeared after changes for > > https://issues.apache.org/jira/browse/CALCITE-35. > > > Since it is a regression, I suggest treating it as a blocker for the > > upcoming release. > > > > > > Kind regards, > > > Volodymyr Vysotskyi > > > > > > On 2022/06/16 06:38:45 Viliam Durina wrote: > > >> I'll try to work on comments in CALCITE-5157 > > >> <https://issues.apache.org/jira/browse/CALCITE-5157> today > > >> > > >> On Wed, 15 Jun 2022 at 07:30, Yanjing Wang <[email protected] > > > > >> wrote: > > >> > > >>> Hi Andrei, > > >>> The followings need review process to merge. > > >>> https://issues.apache.org/jira/browse/CALCITE-4512 > > >>> https://issues.apache.org/jira/browse/CALCITE-5045 > > >>> https://issues.apache.org/jira/browse/CALCITE-5043 > > >>> https://issues.apache.org/jira/browse/CALCITE-4987 > > >>> It would be great if they were fixed in this release. > > >>> > > >>> Dmitry Sysolyatin <[email protected]> 于2022年6月14日周二 17:18写道： > > >>> > > >>>> Hi! > > >>>> It would be good to merge: > > >>>> https://issues.apache.org/jira/browse/CALCITE-5134 > > >>>> https://issues.apache.org/jira/browse/CALCITE-5127 > > >>>> > > >>>> Both of those issues are related to correct execution queries with > > >>>> subqueries. > > >>>> > > >>>> On Tue, Jun 14, 2022 at 6:59 AM Andrei Sereda <[email protected]> > > wrote: > > >>>> > > >>>>> Thanks to all who reviewed the PRs for 1.31 release. > > >>>>> > > >>>>> There are about 16 issues remaining tagged for 1.31 (list > > >>>>> < > > >>>>> > > >>>> > > >>> > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20fixVersion%20%3D%201.31.0%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20%22In%20Review%22%2C%20%22In%20Implementation%22)%20ORDER%20BY%20priority%20DESC > > >>>>>> > > >>>>> ). > > >>>>> > > >>>>> Please let me know which ones are important for this release (and > > I'll > > >>>>> wait) otherwise I'll re-tag those issues for next release 1.32. > > >>>>> > > >>>>> Regards, > > >>>>> Andrei. > > >>>>> > > >>>>> > > >>>>> > > >>>>> On Mon, Jun 13, 2022 at 1:05 PM Julian Hyde < > [email protected]> > > >>>>> wrote: > > >>>>> > > >>>>>> I’m on vacation this week so don’t ask me to review PRs. > > >>>>>> > > >>>>>> It looks like we’re on course for an RC this week, and definitely > > >>> don’t > > >>>>>> wait for me. Maybe we can get a few more PRs merged before then, > and > > >>>> move > > >>>>>> the rest to 1.32 (or clear the fix version if the person who > agreed > > >>> to > > >>>>> fix > > >>>>>> the bug has not responded). > > >>>>>> > > >>>>>> Julian > > >>>>>> > > >>>>>> > > >>>>>>> On Jun 4, 2022, at 2:17 PM, Andrei Sereda <[email protected]> > > >>> wrote: > > >>>>>>> > > >>>>>>> Hello, > > >>>>>>> > > >>>>>>> I have created a JIRA filter > > >>>>>>> < > > >>>>>> > > >>>>> > > >>>> > > >>> > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20fixVersion%20%3D%201.31.0%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20%22In%20Review%22%2C%20%22In%20Implementation%22)%20ORDER%20BY%20priority%20DESC > > >>>>>>> > > >>>>>>> for 1.31 release. There are currently 25 unresolved issues > (planned > > >>>> for > > >>>>>>> 1.31). > > >>>>>>> > > >>>>>>> If you are familiar with some of the JIRA tickets can you please > > >>>> review > > >>>>>> the > > >>>>>>> PRs and resolve the ticket ? > > >>>>>>> > > >>>>>>> The plan is to have an RC in 1-2 weeks. > > >>>>>>> > > >>>>>>> Regards, > > >>>>>>> Andrei. > > >>>>>>> > > >>>>>>> > > >>>>>>> On Sat, Jun 4, 2022 at 6:13 AM Vova Vysotskyi < > > >>> [email protected]> > > >>>>>> wrote: > > >>>>>>> > > >>>>>>>> Hello, > > >>>>>>>> > > >>>>>>>> Could we also include > https://github.com/apache/calcite/pull/2305 > > >>>>> into > > >>>>>>>> this release? > > >>>>>>>> I have rebased it onto the latest master and fixed all merge > > >>>>> conflicts. > > >>>>>>>> > > >>>>>>>> Kind regards, > > >>>>>>>> Volodymyr Vysotskyi > > >>>>>>>> > > >>>>>>>> On 2022/05/30 17:57:28 Julian Hyde wrote: > > >>>>>>>>> Viliam, I marked the Jira case ‘fix in 1.31’ so that someone > will > > >>>> at > > >>>>>>>> least review your PR. > > >>>>>>>>> > > >>>>>>>>>> On May 30, 2022, at 7:09 AM, Viliam Durina > > >>>>>>>> <[email protected]> wrote: > > >>>>>>>>>> > > >>>>>>>>>> Our PR is reasonably simple and as far as I'm aware, it > doesn't > > >>>> need > > >>>>>>>> more > > >>>>>>>>>> changes, we'd be glad to find a reviewer and having it merged: > > >>>>>>>>>> https://github.com/apache/calcite/pull/2808 > > >>>>>>>>>> > > >>>>>>>>>> Viliam > > >>>>>>>>>> > > >>>>>>>>>> On Fri, 27 May 2022 at 21:49, Julian Hyde < > > >>> [email protected] > > >>>>> > > >>>>>>>> wrote: > > >>>>>>>>>> > > >>>>>>>>>>> +1 mid-june release, and thank you to Ruben for sending the > > >>>>> reminder. > > >>>>>>>>>>> > > >>>>>>>>>>> Three weeks ago we had a discussion about the fixVersion [1] > > >>>> field > > >>>>>> and > > >>>>>>>>>>> seemed to reach consensus. There were new responsibilities > for > > >>>> the > > >>>>>>>> release > > >>>>>>>>>>> manager, as described here by Ruben: > > >>>>>>>>>>> > > >>>>>>>>>>>> Before starting the release process for version X, the > > >>>>>>>>>>>> release manager should take a look at Jira and find any > > >>>>>>>>>>>> tickets with fixVersion=X which are not resolved, and > > >>>>>>>>>>>> then act on a case by case basis, I guess starting a > > >>>>>>>>>>>> discussion on each ticket comments (so that > > >>>>>>>>>>>> everything is logged) with the reporter or any other > > >>>>>>>>>>>> contributor which may have done some work on it: > > >>>>>>>>>>>> - If the ticket is considered as a "Blocker", the release > > >>>>>>>>>>>> process shall wait until it is done. > > >>>>>>>>>>>> - If the ticket is not a blocker: > > >>>>>>>>>>>> -- If it is reasonable to assume that it can be part of > > >>>>>>>>>>>> the next (X+1) release (e.g. because work has > > >>>>>>>>>>>> started already, just some elements are left to be > > >>>>>>>>>>>> done etc.), the fixVersion can be changed into X+1. > > >>>>>>>>>>>> -- Otherwise its fixVersion shall be cleared ("unassigned"). > > >>>>>>>>>>> > > >>>>>>>>>>> Andrei, > > >>>>>>>>>>> > > >>>>>>>>>>> Can you carry out the process described above? (It’s bad news > > >>> for > > >>>>>> you, > > >>>>>>>>>>> because there are several issues that have been shunted > forward > > >>>>>>>> several > > >>>>>>>>>>> times, but next release there should be fewer issues.) It > > >>>> basically > > >>>>>>>>>>> involves starting a conversation on every open/reopened JIRA > > >>> case > > >>>>>>>> that is > > >>>>>>>>>>> marked fixVersion=1.31 about a week before the RC. > > >>>>>>>>>>> > > >>>>>>>>>>> If the process works we’ll add it to the HOWTO. > > >>>>>>>>>>> > > >>>>>>>>>>> Julian > > >>>>>>>>>>> > > >>>>>>>>>>> [1] > > >>>>> https://lists.apache.org/thread/g8tjg0qxbot8b69rgv3poo618o3xvob1 > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>>> On May 26, 2022, at 12:58 AM, xiong duan < > [email protected] > > >>>> > > >>>>>>>> wrote: > > >>>>>>>>>>>> > > >>>>>>>>>>>> +1 for mid-June for the first RC. > > >>>>>>>>>>>> > > >>>>>>>>>>>> Benchao Li <[email protected]> 于2022年5月26日周四 10:31写道： > > >>>>>>>>>>>> > > >>>>>>>>>>>>> +1 for mid-June for the first RC. > > >>>>>>>>>>>>> Thanks Ruben for driving this, and Andrei for being the RM. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> For me, I have two PRs[1][2] which I think it's good to > have > > >>>> them > > >>>>>> in > > >>>>>>>>>>> 1.31.0 > > >>>>>>>>>>>>> And for other issues which I've not opened pr yet, I think > > >>> it's > > >>>>>>>>>>> reasonable > > >>>>>>>>>>>>> to postpone them to next version. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> [1] https://github.com/apache/calcite/pull/2791 > > >>>>>>>>>>>>> [2] https://github.com/apache/calcite/pull/2813 > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Andrei Sereda <[email protected]> 于2022年5月26日周四 09:16写道： > > >>>>>>>>>>>>> > > >>>>>>>>>>>>>>> Andrei, are you still available for the task? > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Yes. I'm happy to be the Release Manager for 1.31 > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> On Wed, May 25, 2022 at 9:15 PM Chunwei Lei < > > >>>>>>>> [email protected]> > > >>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> Thank you for taking care of this, Ruben. > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> +1 for mid-June for the first RC. > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> Best, > > >>>>>>>>>>>>>>> Chunwei > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> On Wed, May 25, 2022 at 4:26 PM Ruben Q L < > > >>> [email protected] > > >>>>> > > >>>>>>>> wrote: > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> Hello, > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> It has been more than two months since our last release > > >>> [1], > > >>>>> and > > >>>>>>>> I > > >>>>>>>>>>>>>> think > > >>>>>>>>>>>>>>> we > > >>>>>>>>>>>>>>>> should make an effort to continue keeping the rhythm of > > >>> one > > >>>>>>>> release > > >>>>>>>>>>>>>> every > > >>>>>>>>>>>>>>>> two months approximately. > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> If I am not mistaken, the next release manager would be > > >>>> Andrei > > >>>>>>>> Sereda > > >>>>>>>>>>>>>>> [2]. > > >>>>>>>>>>>>>>>> Andrei, are you still available for the task? > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> As usual, according to our Jira dashboard [3] and Github > > >>>> [4], > > >>>>>>>> there > > >>>>>>>>>>>>> are > > >>>>>>>>>>>>>>>> many pending issues that could / should be part of the > > >>>>> release. > > >>>>>>>> I'd > > >>>>>>>>>>>>>>> propose > > >>>>>>>>>>>>>>>> to make a collective effort to try to clean up our 1.31 > > >>>>> backlog: > > >>>>>>>>>>>>>> complete > > >>>>>>>>>>>>>>>> and merge the PRs which are in a reasonably good state, > > >>> and > > >>>>> push > > >>>>>>>> back > > >>>>>>>>>>>>>> to > > >>>>>>>>>>>>>>>> 1.32 (or unassigned version) the Jira tickets that are > not > > >>>>>>>> advanced > > >>>>>>>>>>>>>>> enough > > >>>>>>>>>>>>>>>> to be part of this release. Shall we give ourselves > around > > >>>> two > > >>>>>>>> weeks > > >>>>>>>>>>>>>> for > > >>>>>>>>>>>>>>>> this and aim at mid-June for the first RC? WDYT? > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> Best regards, > > >>>>>>>>>>>>>>>> Ruben > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> [1] > > >>>>> https://calcite.apache.org/news/2022/03/19/release-1.30.0/ > > >>>>>>>>>>>>>>>> [2] > > >>>>>>>> > https://lists.apache.org/thread/ykbhhxmljw6wg50rxs6ypp35173hlkdv > > >>>>>>>>>>>>>>>> [3] > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > >>>>>>>>>>>>>>>> [4] https://github.com/apache/calcite/pulls > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> -- > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Best, > > >>>>>>>>>>>>> Benchao Li > > >>>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> -- > > >>>>>>>>>> This message contains confidential information and is intended > > >>>> only > > >>>>>>>> for the > > >>>>>>>>>> individuals named. If you are not the named addressee you > should > > >>>> not > > >>>>>>>>>> disseminate, distribute or copy this e-mail. Please notify the > > >>>>> sender > > >>>>>>>>>> immediately by e-mail if you have received this e-mail by > > >>> mistake > > >>>>> and > > >>>>>>>>>> delete this e-mail from your system. E-mail transmission > cannot > > >>> be > > >>>>>>>>>> guaranteed to be secure or error-free as information could be > > >>>>>>>> intercepted, > > >>>>>>>>>> corrupted, lost, destroyed, arrive late or incomplete, or > > >>> contain > > >>>>>>>> viruses. > > >>>>>>>>>> The sender therefore does not accept liability for any errors > or > > >>>>>>>> omissions > > >>>>>>>>>> in the contents of this message, which arise as a result of > > >>> e-mail > > >>>>>>>>>> transmission. If verification is required, please request a > > >>>>> hard-copy > > >>>>>>>>>> version. -Hazelcast > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>> > > >>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > >> > > >> -- > > >> This message contains confidential information and is intended only > for > > the > > >> individuals named. If you are not the named addressee you should not > > >> disseminate, distribute or copy this e-mail. Please notify the sender > > >> immediately by e-mail if you have received this e-mail by mistake and > > >> delete this e-mail from your system. E-mail transmission cannot be > > >> guaranteed to be secure or error-free as information could be > > intercepted, > > >> corrupted, lost, destroyed, arrive late or incomplete, or contain > > viruses. > > >> The sender therefore does not accept liability for any errors or > > omissions > > >> in the contents of this message, which arise as a result of e-mail > > >> transmission. If verification is required, please request a hard-copy > > >> version. -Hazelcast > > >> > > > > >
