The latest commits look good. Only a few cosmetic changes that would be nice to do - Add missing/fix javadoc to ExecutorServiceManager (its a SPI interface so full javadoc shows professionalism) - Add missing/fix javadoc to ThreadPoolFactory (its a SPI interface so full javadoc shows professionalism) - ThreadPoolProfile as you override clone() you could consider implementing Cloneable interface as well - The parameter name for addDefaults could imho be improved to be other instead of defaultProfile2 which seems a bit odd name Also the javadoc parameter is not described
-- Claus Ibsen ----------------- FuseSource Email: cib...@fusesource.com Web: http://fusesource.com Twitter: davsclaus, fusenews Blog: http://davsclaus.blogspot.com/ Author of Camel in Action: http://www.manning.com/ibsen/
