On Fri, Aug 19, 2011 at 2:22 PM, Christian Schneider <ch...@die-schneider.net> wrote: > Committed the changes. > > I even built before I committed to show extra professionalism :-) >
Ah that is maybe too professional. Sometimes you have to leave easy mistakes in for others to fix :) > Christian > > Am 19.08.2011 10:00, schrieb Claus Ibsen: >> >> The latest commits look good. >> >> Only a few cosmetic changes that would be nice to do >> - Add missing/fix javadoc to ExecutorServiceManager (its a SPI >> interface so full javadoc shows professionalism) >> - Add missing/fix javadoc to ThreadPoolFactory (its a SPI interface so >> full javadoc shows professionalism) >> - ThreadPoolProfile as you override clone() you could consider >> implementing Cloneable interface as well >> - The parameter name for addDefaults could imho be improved to be >> other instead of defaultProfile2 which seems a bit odd name >> Also the javadoc parameter is not described >> >> > > > -- > -- > Christian Schneider > http://www.liquid-reality.de > > Open Source Architect > Talend Application Integration Division http://www.talend.com > > -- Claus Ibsen ----------------- FuseSource Email: cib...@fusesource.com Web: http://fusesource.com Twitter: davsclaus, fusenews Blog: http://davsclaus.blogspot.com/ Author of Camel in Action: http://www.manning.com/ibsen/
