Hi Gregor, I've committed my fixes.
--- Luca Burgazzoli On Mon, Apr 24, 2017 at 6:10 PM, Luca Burgazzoli <lburgazz...@gmail.com> wrote: > Hi Gregor, > > I'm running a local build to see if there is any blocking issue some > JIRA I'd like to include [1][2][3], it should not take too much and > I'll post here as son as I have merged my work on master. > > > [1] https://issues.apache.org/jira/browse/CAMEL-11190 > [2] https://issues.apache.org/jira/browse/CAMEL-11191 > [3] https://issues.apache.org/jira/browse/CAMEL-11192 > > > --- > Luca Burgazzoli > > > On Mon, Apr 24, 2017 at 11:11 AM, Gregor Zurowski > <gre...@list.zurowski.org> wrote: >> Hi Claus, >> >> Alright, I guess this is the best we can do for now. I also agree on >> removing the regular examples from the release. I would actually also >> move them into a separate artifact group. Currently they use the >> group ID org.apache.camel, so we could move them into >> org.apache.camel.example or similar. >> >> I will re-cut the release candidate tonight. >> >> Thanks, >> Gregor >> >> >> On Mon, Apr 24, 2017 at 10:49 AM, Claus Ibsen <claus.ib...@gmail.com> wrote: >>> Hi Gregor >>> >>> So we have now fixed this by turning of those connector examples as >>> they should not be in the release. >>> >>> We will later re-organize this and see what to do if any of this is >>> needed as releases JAR in maven central. >>> You could consider the same for the regular examples, they should >>> maybe not be released either to maven central. >>> But its a talk for another day. >>> >>> The master branch should be ready for a re-cut of the release. >>> >>> Let us know when you are able to work on this again. Thanks a lot for >>> helping with the releases. >>> >>> >>> >>> >>> >>> >>> >>> >>> On Mon, Apr 24, 2017 at 10:22 AM, Claus Ibsen <claus.ib...@gmail.com> wrote: >>>> Hi Gregor >>>> >>>> Okay so the connector examples are not yet intended for release (if >>>> they ever would be). >>>> So I have skipped them. >>>> >>>> People can try them from the source code as they do with the other >>>> examples. That works fine. >>>> >>>> For a release process we may also need to add some extra logic so the >>>> SNAPSHOT versions in the json files etc are replaced as part of a >>>> release build. AFAIR you need to run 2 x build, to make it updated, >>>> which you can't usually. >>>> >>>> >>>> >>>> On Sun, Apr 23, 2017 at 10:25 PM, Gregor Zurowski >>>> <gre...@list.zurowski.org> wrote: >>>>> Hi Everyone: >>>>> >>>>> I have finally managed to resolve all memory-related and >>>>> machine-related issues, but I am hitting another road block in the >>>>> release process. The process fails when the new connector examples >>>>> are about to get pushed to the artifact repository: >>>>> >>>>> [INFO] [ERROR] Failed to execute goal >>>>> org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy >>>>> (default-deploy) on project beverage-component: Failed to deploy >>>>> artifacts: Could not transfer artifact >>>>> org.foo:beverage-component:jar:2.19.0 from/to apache.releases.https >>>>> (https://repository.apache.org/service/local/staging/deploy/maven2): >>>>> Failed to transfer file: >>>>> https://repository.apache.org/service/local/staging/deploy/maven2/org/foo/beverage-component/2.19.0/beverage-component-2.19.0.jar. >>>>> Return code is: 400, ReasonPhrase: Bad Request. -> [Help 1] >>>>> >>>>> This is likely caused by the group ID "org.foo" that is used in these >>>>> modules, which will not be accepted by the Apache artifact repository. >>>>> >>>>> I could easily change the group ID of these examples to something like >>>>> "org.apache.camel.example.connector". While attempting to change >>>>> this, I realized that there are JSON files in the example directories >>>>> that directly reference these artifacts, for example in >>>>> /salesforce-upsert-contact-connector/src/main/resources/camel-connector.json: >>>>> >>>>> "groupId" : "org.foo", >>>>> "artifactId" : "salesforce-upsert-contact-connector", >>>>> "version" : "2.19.0-SNAPSHOT" >>>>> >>>>> I can update the group ID here as well, but the release process is not >>>>> prepared to handle any of these JSON files for updating the version >>>>> elements, i.e. 2.19.0-SNAPSHOT should have been rewritten to 2.19.0 >>>>> within the release preparation step. >>>>> >>>>> Please let me know how to proceed here. Once we resolve this, I will >>>>> restart the release. >>>>> >>>>> Thanks, >>>>> Gregor >>>>> >>>>> >>>>> On Sat, Apr 22, 2017 at 3:00 PM, Claus Ibsen <claus.ib...@gmail.com> >>>>> wrote: >>>>>> Hi Gregor >>>>>> >>>>>> Sorry for adding that CS error this morning. I guess the extra text in >>>>>> that exception message may have caused the line to be too long? >>>>>> >>>>>> I noticed some Maven WARNs about some examples was a bit wrong with >>>>>> bundle vs jar. So I aligned them and just pushed. >>>>>> I will step away from the computer so you should have a quiet time to >>>>>> work on the release. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Sat, Apr 22, 2017 at 2:52 PM, Gregor Zurowski >>>>>> <gre...@list.zurowski.org> wrote: >>>>>>> Hi Claus, >>>>>>> >>>>>>> I am still working on the release, just found some CS issues. >>>>>>> >>>>>>> I am using a different box now, because the OOME problems were >>>>>>> definitely caused by some issues with the machine I was using >>>>>>> previously. >>>>>>> >>>>>>> Will keep you posted. >>>>>>> >>>>>>> Thanks, >>>>>>> Gregor >>>>>>> >>>>>>> >>>>>>> On Sat, Apr 22, 2017 at 11:02 AM, Claus Ibsen <claus.ib...@gmail.com> >>>>>>> wrote: >>>>>>>> Hi >>>>>>>> >>>>>>>> Building the release candidate takes up a lot of memory and Gregor has >>>>>>>> hit a OOME with 6gb. >>>>>>>> >>>>>>>> We are cleaning up a bit in the project to upgrade some of the maven >>>>>>>> plugins to use newer versions and reduce some cruft in the assembly. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Sat, Apr 22, 2017 at 9:20 AM, Claus Ibsen <claus.ib...@gmail.com> >>>>>>>> wrote: >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> Looking at the CI tests then they all look good (blue/green) >>>>>>>>> https://builds.apache.org/view/A-D/view/Camel/ >>>>>>>>> >>>>>>>>> .. except for the spring-boot tests which had two tests for >>>>>>>>> camel-core-xml and camel-spring-dm which does not make sense at all so >>>>>>>>> I have removed them. This should make this job blue as well. >>>>>>>>> >>>>>>>>> >>>>>>>>> On Sat, Apr 22, 2017 at 9:13 AM, Claus Ibsen <claus.ib...@gmail.com> >>>>>>>>> wrote: >>>>>>>>>> Hi Gregor >>>>>>>>>> >>>>>>>>>> I can see you committed some fixed last evening. >>>>>>>>>> >>>>>>>>>> Do you think that you found all the "bugs" in terms of building a >>>>>>>>>> release candidate, or do we have more problems? >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Apr 21, 2017 at 9:22 PM, Gregor Zurowski >>>>>>>>>> <gre...@list.zurowski.org> wrote: >>>>>>>>>>> Hi Claus, >>>>>>>>>>> >>>>>>>>>>> Thanks for taking care of this. I will start building the release >>>>>>>>>>> candidate now. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Gregor >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Fri, Apr 21, 2017 at 9:11 PM, Claus Ibsen >>>>>>>>>>> <claus.ib...@gmail.com> wrote: >>>>>>>>>>>> Hi >>>>>>>>>>>> >>>>>>>>>>>> I have just pushed fixes for RAT license check and CS checkstyle. >>>>>>>>>>>> They >>>>>>>>>>>> all pass now. >>>>>>>>>>>> I also added a few missing JARs in the release kit (the big >>>>>>>>>>>> zip/tarball with all the JARs) >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Fri, Apr 21, 2017 at 2:51 PM, Gregor Zurowski >>>>>>>>>>>> <gre...@list.zurowski.org> wrote: >>>>>>>>>>>>> Hi Everyone, >>>>>>>>>>>>> >>>>>>>>>>>>> That is great to hear, I will create the release candidate over >>>>>>>>>>>>> the >>>>>>>>>>>>> weekend, if all fixes are available on the master branch. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Gregor >>>>>>>>>>>>> >>>>>>>>>>>>> On Fri, Apr 21, 2017 at 1:59 PM, Zoran Regvart >>>>>>>>>>>>> <zo...@regvart.com> wrote: >>>>>>>>>>>>>> Hi Cameleers, >>>>>>>>>>>>>> Andrea and Dmitry reviewed CAMEL-11181 and it was just pushed to >>>>>>>>>>>>>> master, >>>>>>>>>>>>>> >>>>>>>>>>>>>> thank you :) >>>>>>>>>>>>>> >>>>>>>>>>>>>> zoran >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Fri, Apr 21, 2017 at 1:32 PM, Claus Ibsen >>>>>>>>>>>>>> <claus.ib...@gmail.com> wrote: >>>>>>>>>>>>>>> And Zoran has CAMEL-11181 outstanding. >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Zoran Regvart >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Claus Ibsen >>>>>>>>>>>> ----------------- >>>>>>>>>>>> http://davsclaus.com @davsclaus >>>>>>>>>>>> Camel in Action 2: https://www.manning.com/ibsen2 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Claus Ibsen >>>>>>>>>> ----------------- >>>>>>>>>> http://davsclaus.com @davsclaus >>>>>>>>>> Camel in Action 2: https://www.manning.com/ibsen2 >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Claus Ibsen >>>>>>>>> ----------------- >>>>>>>>> http://davsclaus.com @davsclaus >>>>>>>>> Camel in Action 2: https://www.manning.com/ibsen2 >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Claus Ibsen >>>>>>>> ----------------- >>>>>>>> http://davsclaus.com @davsclaus >>>>>>>> Camel in Action 2: https://www.manning.com/ibsen2 >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Claus Ibsen >>>>>> ----------------- >>>>>> http://davsclaus.com @davsclaus >>>>>> Camel in Action 2: https://www.manning.com/ibsen2 >>>> >>>> >>>> >>>> -- >>>> Claus Ibsen >>>> ----------------- >>>> http://davsclaus.com @davsclaus >>>> Camel in Action 2: https://www.manning.com/ibsen2 >>> >>> >>> >>> -- >>> Claus Ibsen >>> ----------------- >>> http://davsclaus.com @davsclaus >>> Camel in Action 2: https://www.manning.com/ibsen2
