Hi Thanks for your help and patience. I’ve provided a PR to fix this but as Otavoi is currently fixing same stuff I get conflicts with main branch. I’ve already fixed one of those conflicts, and will try to fix the current one. Then we should be good to go for a review I think:
https://github.com/apache/camel/pull/5725 <https://github.com/apache/camel/pull/5725> Babak > On 21 Jun 2021, at 09:44, Claus Ibsen <claus.ib...@gmail.com> wrote: > > Hi > > So the new code changes works with 8.40, so I downgraded to that. > Then Babak can upgrade to 8.43 locally and fix the source code along the way. > Then after the 3.11 LTS we can upgrade to 8.43 and get the rest fixed > before 3.12. > > On Mon, Jun 21, 2021 at 9:39 AM Guillaume Nodet <gno...@apache.org> wrote: >> >> I suppose another way would be to upgrade to 8.43, disable the new rules, >> then work on re-enabling them later if it makes sense... >> >> Le lun. 21 juin 2021 à 09:37, Claus Ibsen <claus.ib...@gmail.com> a écrit : >> >>> Hi >>> >>> Yes the CS are very likely too many to fix up in time before the >>> release is being cut later this week. >>> >>> To be sure that the old version would work with the new changes, then >>> lets try to go back to 8.40 and keep the code changes. If this works >>> then you can just do a local 8.43 upgrade and then upgrade the code as >>> you get time. >>> Then the CS works for the rest of us in the mean time. >>> >>> On Mon, Jun 21, 2021 at 7:26 AM Andrea Cosentino <anco...@gmail.com> >>> wrote: >>>> >>>> Thanks for this. >>>> >>>> Since we are going to release the next LTS soon, we need to deal with >>> these >>>> errors a bit faster or eventually revert and postpone to 3.12.0, because >>>> the sourcecheck is part of the release profile. >>>> >>>> https://github.com/apache/camel/blob/main/pom.xml#L375 >>>> >>>> Thanks >>>> >>>> Il giorno lun 21 giu 2021 alle ore 00:13 Babak Vahdat < >>>> babak.vah...@swissonline.ch> ha scritto: >>>> >>>>> Hi >>>>> >>>>> Upgrading the Maven plugin com.puppycrawl.tools:checkstyle from the >>>>> version 8.40 to 8.43 has caused tons of checkstyle validations to fail. >>>>> >>>>> I'm on it and need to find some more free cycle to fix the remaining >>> ones. >>>>> >>>>> Babak >>> >>> >>> >>> -- >>> Claus Ibsen >>> ----------------- >>> http://davsclaus.com @davsclaus >>> Camel in Action 2: https://www.manning.com/ibsen2 >>> >> >> >> -- >> ------------------------ >> Guillaume Nodet > > > > -- > Claus Ibsen > ----------------- > http://davsclaus.com @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2
