Hi Just rebased on the main branch and created a new PR, please review
https://github.com/apache/camel/pull/5734 <https://github.com/apache/camel/pull/5734> Babak > On 21 Jun 2021, at 16:32, Babak Vahdat <babak.vah...@swissonline.ch> wrote: > > >> On 21 Jun 2021, at 16:00, Guillaume Nodet <gno...@apache.org> wrote: >> >> @Claus Yes, I wasn't questioning the schedule at all. >> >> However, if the code is validated with checkstyle 8.40 and not 8.43, I was >> wondering if those new (or modified) rules do make sense for camel or we >> should skip them when working on the upgrade for 3.12. Babak, can you give >> some hints about what kind of rules fail with 8.43 ? >> > > It’s always about this check which pops up as an error: > > https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheck.html > > <https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheck.html> > > For example on this line: > > https://github.com/apache/camel/blob/main/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelXmlRestDslParserHelper.java#L88 > > <https://github.com/apache/camel/blob/main/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelXmlRestDslParserHelper.java#L88> > > [ERROR] > /Users/bvahdat/dev/workspace/camel/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelXmlRestDslParserHelper.java:88:20: > Unnecessary parentheses around expression. [UnnecessaryParentheses] > > In our cases it’s mostly (not always) because of the fact that logical and > operator in java has higher precedence compared to logical or, so why > unnecessary parentheses. > > I think it has to do with the following in 8.43 > https://github.com/checkstyle/checkstyle/issues/9957 > <https://github.com/checkstyle/checkstyle/issues/9957> which actually seems > to be a regression to me as this should be considered as a warning and not an > error (according to Javadoc above). > > Babak > >> Guillaume >> >> Le lun. 21 juin 2021 à 09:44, Claus Ibsen <claus.ib...@gmail.com> a écrit : >> >>> Hi >>> >>> So the new code changes works with 8.40, so I downgraded to that. >>> Then Babak can upgrade to 8.43 locally and fix the source code along the >>> way. >>> Then after the 3.11 LTS we can upgrade to 8.43 and get the rest fixed >>> before 3.12. >>> >>> On Mon, Jun 21, 2021 at 9:39 AM Guillaume Nodet <gno...@apache.org> wrote: >>>> >>>> I suppose another way would be to upgrade to 8.43, disable the new rules, >>>> then work on re-enabling them later if it makes sense... >>>> >>>> Le lun. 21 juin 2021 à 09:37, Claus Ibsen <claus.ib...@gmail.com> a >>> écrit : >>>> >>>>> Hi >>>>> >>>>> Yes the CS are very likely too many to fix up in time before the >>>>> release is being cut later this week. >>>>> >>>>> To be sure that the old version would work with the new changes, then >>>>> lets try to go back to 8.40 and keep the code changes. If this works >>>>> then you can just do a local 8.43 upgrade and then upgrade the code as >>>>> you get time. >>>>> Then the CS works for the rest of us in the mean time. >>>>> >>>>> On Mon, Jun 21, 2021 at 7:26 AM Andrea Cosentino <anco...@gmail.com> >>>>> wrote: >>>>>> >>>>>> Thanks for this. >>>>>> >>>>>> Since we are going to release the next LTS soon, we need to deal with >>>>> these >>>>>> errors a bit faster or eventually revert and postpone to 3.12.0, >>> because >>>>>> the sourcecheck is part of the release profile. >>>>>> >>>>>> https://github.com/apache/camel/blob/main/pom.xml#L375 >>>>>> >>>>>> Thanks >>>>>> >>>>>> Il giorno lun 21 giu 2021 alle ore 00:13 Babak Vahdat < >>>>>> babak.vah...@swissonline.ch> ha scritto: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> Upgrading the Maven plugin com.puppycrawl.tools:checkstyle from the >>>>>>> version 8.40 to 8.43 has caused tons of checkstyle validations to >>> fail. >>>>>>> >>>>>>> I'm on it and need to find some more free cycle to fix the >>> remaining >>>>> ones. >>>>>>> >>>>>>> Babak >>>>> >>>>> >>>>> >>>>> -- >>>>> Claus Ibsen >>>>> ----------------- >>>>> http://davsclaus.com @davsclaus >>>>> Camel in Action 2: https://www.manning.com/ibsen2 >>>>> >>>> >>>> >>>> -- >>>> ------------------------ >>>> Guillaume Nodet >>> >>> >>> >>> -- >>> Claus Ibsen >>> ----------------- >>> http://davsclaus.com @davsclaus >>> Camel in Action 2: https://www.manning.com/ibsen2 >>> >> >> >> -- >> ------------------------ >> Guillaume Nodet >
