Thanks for looking into this and fixing it. Gregor
On Fri, Dec 17, 2021 at 5:19 AM David Jencks <david.a.jen...@gmail.com> wrote: > > FWIW I’m working on a local build setup for (main) camel and discovered some > gaps in @djencks/antora-source-watch exposed by the `components` component > being distributed across `camel` and `camel-spring-boot`. Perhaps it will be > ready tomorrow. > > I’d find it much easier to take complaints about the website build seriously > if there was active consideration and discussion around my attempts to > improve the situation. It’s been a couple days since my recent email on the > subject with no responses that I can see. In particular future(1) would > probably mean a local build of a subproject to check for errors could be done > with no preparation other than having camel-website cloned appropriately, > node installed, and take about a minute. It would be great to have a CI > check as well, but this or even the local builds I’m working on now would be > far better than the current situation where I think no one knows about the > instructions > https://camel.apache.org/manual/improving-the-documentation.html#_local_build_instructions > > <https://camel.apache.org/manual/improving-the-documentation.html#_local_build_instructions> > and they are far too hard to follow. > > David Jencks > > > On Dec 16, 2021, at 2:46 PM, David Jencks <david.a.jen...@gmail.com> wrote: > > > > I followed the link Gregor provided and see this: > > > > ➤ YN0000: [18:59:31.230] WARN (asciidoctor): skipping reference to missing > > attribute: headername > > ➤ YN0000: file: > > docs/components/modules/ROOT/pages/salesforce-component.adoc > > ➤ YN0000: source: https://github.com/apache/camel.git > > <https://github.com/apache/camel.git> (refname: main, start path: > > docs/components) > > ➤ YN0000: [18:59:31.235] WARN (asciidoctor): skipping reference to missing > > attribute: id > > ➤ YN0000: file: > > docs/components/modules/ROOT/pages/salesforce-component.adoc > > ➤ YN0000: source: https://github.com/apache/camel.git > > <https://github.com/apache/camel.git> (refname: main, start path: > > docs/components) > > > > > > I’m not sure how much more clear the build could possibly be about what is > > wrong??? > > > > Back before Antora 3 these errors would still be present but not result in > > a failed build. You could look at the console output, but no one ever did. > > > > To fix: > > > > - the indicated file is a symlink, so follow it to it’s source > > components/camel-salesforce/camel-salesforce-component/src/main/docs/salesforce-component.adoc > > > > - look at git log to see who to blame…. > > > > - find the newly added non-attributes {header name} and {id} and escape them > > > > ... > > > > https://github.com/apache/camel/pull/6550 > > <https://github.com/apache/camel/pull/6550> > > > > It’s not nearly easy enough to do a build to see if you’ve broken the site, > > but my POC makes it at least plausible. > > > > Browser plugins and the Intellij asciidoc plugin are not an adequate > > replacement for building the site. > > > > I suggest that no one change an adoc file without at least checking the > > antora build locally. Without local checks and PR builds we can expect the > > website to be always broken. Unfortunately I still don’t know of an > > easy-enough way to have PR builds. > > > > David Jencks > > > >> On Dec 16, 2021, at 11:38 AM, Andrea Cosentino <anco...@gmail.com > >> <mailto:anco...@gmail.com>> wrote: > >> > >> To be clear, I really appreciate the work done on docs and website, but > >> it's really frustrating to get a different error each time you try to have > >> a green ci build. > >> > >> Il gio 16 dic 2021, 20:36 Andrea Cosentino <anco...@gmail.com > >> <mailto:anco...@gmail.com>> ha scritto: > >> > >>> Thanks Gregor for spending your time on this. > >>> > >>> I would like to stress once again how much it's becoming non-deterministic > >>> to build the website. > >>> > >>> This is becoming everyday more complicated than it should be. > >>> > >>> I think we need to focus on this. Because we shouldn't postpone a release > >>> for reason like this. > >>> > >>> Building the website should be something like black magic and voodoo > >>> invocation. It should work much more easily. > >>> > >>> I'll start another dev discussion about this argument. > >>> > >>> Il gio 16 dic 2021, 20:17 Gregor Zurowski <gre...@list.zurowski.org > >>> <mailto:gre...@list.zurowski.org>> ha > >>> scritto: > >>> > >>>> Hi Everyone: > >>>> > >>>> I wanted to finish up the steps necessary to release Camel 3.14.0, but > >>>> I am running into issues with the website build: > >>>> > >>>> ``` > >>>> YN0000: ERROR: "build:antora" exited with 1. > >>>> YN0000: The command failed for workspaces that are depended upon by > >>>> other workspaces; can't satisfy the dependency graph > >>>> ``` > >>>> See: > >>>> https://ci-builds.apache.org/job/Camel/job/Camel.website/job/main/630/console > >>>> > >>>> <https://ci-builds.apache.org/job/Camel/job/Camel.website/job/main/630/console> > >>>> > >>>> Any ideas why that's happening? > >>>> > >>>> Thanks in advance > >>>> Gregor > >>>> > >>> > > >
