Looking at the ticket, I’d say Jon’s concern is legitimate. The segfaults Jon is seeing are probably caused by paxos V2 when combined with off heap memtables for the reason Benedict suggests in the JIRA. This problem will continue to exist in 5.0. Unfortunately, it looks like the patch posted is not enough to address the issue and will need to be a bit more involved to properly fix the problem.
While this is not a regression, I think Jon’s point about trie memtables increasing usage of off heap memtables is a good one, and anyway we shouldn’t be doing major releases with known process crashing bugs. So I’m voting -1 on this release and will work with Jon and Benedict to get this fixed. Thanks, Blake > On Jun 26, 2024, at 6:47 AM, Josh McKenzie <jmcken...@apache.org> wrote: > > Blake or Benedict - can either of you speak to Jon's concerns around > CASSANDRA-19668? > > On Wed, Jun 26, 2024, at 12:18 AM, Jeff Jirsa wrote: >> >> +1 >> >> >> >>> On Jun 25, 2024, at 5:04 AM, Mick Semb Wever <m...@apache.org> wrote: >>> >>> >>> Proposing the test build of Cassandra 5.0-rc1 for release. >>> >>> sha1: b43f0b2e9f4cb5105764ef9cf4ece404a740539a >>> Git: https://github.com/apache/cassandra/tree/5.0-rc1-tentative >>> Maven Artifacts: >>> https://repository.apache.org/content/repositories/orgapachecassandra-1336/org/apache/cassandra/cassandra-all/5.0-rc1/ >>> >>> The Source and Build Artifacts, and the Debian and RPM packages and >>> repositories, are available here: >>> https://dist.apache.org/repos/dist/dev/cassandra/5.0-rc1/ >>> >>> The vote will be open for 72 hours (longer if needed). Everyone who has >>> tested the build is invited to vote. Votes by PMC members are considered >>> binding. A vote passes if there are at least three binding +1s and no -1's. >>> >>> [1]: CHANGES.txt: >>> https://github.com/apache/cassandra/blob/5.0-rc1-tentative/CHANGES.txt >>> [2]: NEWS.txt: >>> https://github.com/apache/cassandra/blob/5.0-rc1-tentative/NEWS.txt
