AngersZhuuuu commented on code in PR #990:
URL:
https://github.com/apache/incubator-celeborn/pull/990#discussion_r1029035773
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -312,12 +318,19 @@ class PushDataHandler extends BaseMessageHandler with
Logging {
}
if (loc == null) {
val (mapId, attemptId) = getMapAttempt(body)
- if (shuffleMapperAttempts.containsKey(shuffleKey)
- && -1 != shuffleMapperAttempts.get(shuffleKey)(mapId)) {
- val msg = s"Receive push data from speculative task(shuffle
$shuffleKey, map $mapId," +
- s" attempt $attemptId), but this mapper has already been ended."
- logInfo(msg)
-
wrappedCallback.onSuccess(ByteBuffer.wrap(Array[Byte](StatusCode.STAGE_ENDED.getValue)))
+ if (shuffleMapperAttempts.containsKey(shuffleKey)) {
+ if (-1 != shuffleMapperAttempts.get(shuffleKey)(mapId)) {
+ val msg =
+ s"Receive push merged data from speculative task(shuffle
$shuffleKey, map $mapId," +
+ s" attempt $attemptId), but this mapper has already been
ended."
+ logInfo(msg)
+
wrappedCallback.onSuccess(ByteBuffer.wrap(Array[Byte](StatusCode.STAGE_ENDED.getValue)))
+ } else {
Review Comment:
Batch commit partition files will just pass a empty array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
