AngersZhuuuu commented on code in PR #990:
URL:
https://github.com/apache/incubator-celeborn/pull/990#discussion_r1030000959
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -246,6 +283,88 @@ class LifecycleManager(appId: String, val conf:
CelebornConf) extends RpcEndpoin
batchHandleChangePartitionRequestInterval,
TimeUnit.MILLISECONDS)
}
+
+ batchHandleCommitPartitionSchedulerThread.foreach {
+ _.scheduleAtFixedRate(
+ new Runnable {
+ override def run(): Unit = {
+ logWarning("Batch commit hard split partition")
+ commitPartitionRequests.asScala.foreach { case (shuffleId,
requests) =>
+ batchHandleCommitPartitionExecutors.submit {
+ new Runnable {
+ override def run(): Unit = {
+ val shuffleCommittedInfo =
committedPartitionInfo.get(shuffleId)
Review Comment:
I know, but I prefer to do this refactor next, I don't want one pr to be too
complex, refactor this based on this pr can be more clear. WDYT @waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
