waitinfuture commented on code in PR #990:
URL:
https://github.com/apache/incubator-celeborn/pull/990#discussion_r1032895699
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -155,12 +155,18 @@ class PushDataHandler extends BaseMessageHandler with
Logging {
if (location == null) {
val (mapId, attemptId) = getMapAttempt(body)
- if (shuffleMapperAttempts.containsKey(shuffleKey) &&
- -1 != shuffleMapperAttempts.get(shuffleKey)(mapId)) {
- // partition data has already been committed
- logInfo(s"Receive push data from speculative task(shuffle $shuffleKey,
map $mapId, " +
- s" attempt $attemptId), but this mapper has already been ended.")
-
wrappedCallback.onSuccess(ByteBuffer.wrap(Array[Byte](StatusCode.STAGE_ENDED.getValue)))
+ if (shuffleMapperAttempts.containsKey(shuffleKey)) {
+ if (-1 != shuffleMapperAttempts.get(shuffleKey)(mapId)) {
Review Comment:
After handling hard-split commitFiles, the mapperAttempts will always be -1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
