PengZheng commented on code in PR #817:
URL: https://github.com/apache/celix/pull/817#discussion_r2734563497
##########
conanfile.py:
##########
@@ -387,7 +388,10 @@ def generate(self):
if "libcurl" in lst:
tc.cache_variables["BUILD_ERROR_INJECTOR_CURL"] = "ON"
tc.cache_variables["CELIX_ERR_BUFFER_SIZE"] =
str(self.options.celix_err_buffer_size)
- # tc.cache_variables["CMAKE_PROJECT_Celix_INCLUDE"] =
os.path.join(self.build_folder, "conan_paths.cmake")
+ if self.options.enable_gcc_analyzer and self.settings.compiler ==
"gcc":
Review Comment:
@pnoltes means the setting of `CMAKE_C_FLAGS`/`CMAKE_CXX_FLAGS` is not
needed, which is already included in CMAKE. `enable_gcc_analyzer` is still
needed to enable the corresponding CMake option (`ENABLE_GCC_ANALYZER`).
My understanding is that `-fanalyzer` gcc option does not affect binary
output, and thus we should remove `enable_gcc_analyzer` from the package id
computation, i.e. adding `del self.info.options.enable_gcc_analyzer` to the
`package_id` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
