moelksasbyahmed commented on code in PR #817:
URL: https://github.com/apache/celix/pull/817#discussion_r2759680792
##########
conanfile.py:
##########
@@ -387,7 +390,8 @@ def generate(self):
if "libcurl" in lst:
tc.cache_variables["BUILD_ERROR_INJECTOR_CURL"] = "ON"
tc.cache_variables["CELIX_ERR_BUFFER_SIZE"] =
str(self.options.celix_err_buffer_size)
- # tc.cache_variables["CMAKE_PROJECT_Celix_INCLUDE"] =
os.path.join(self.build_folder, "conan_paths.cmake")
+ tc.cache_variables["ENABLE_GCC_ANALYZER"] =
self.options.enable_gcc_analyzer
Review Comment:
hi @PengZheng i saw the failed triggred workflow i added
`"-Wno-analyzer-shift-count-negative" ` to suppress the errors of shift count
registers as c and cpp will give an error if the bitwise shift operator may be
performed with a negative number i squashed some related commits is there a
another thing i should consider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]