PengZheng commented on code in PR #817:
URL: https://github.com/apache/celix/pull/817#discussion_r2744310027
##########
conanfile.py:
##########
@@ -387,7 +388,10 @@ def generate(self):
if "libcurl" in lst:
tc.cache_variables["BUILD_ERROR_INJECTOR_CURL"] = "ON"
tc.cache_variables["CELIX_ERR_BUFFER_SIZE"] =
str(self.options.celix_err_buffer_size)
- # tc.cache_variables["CMAKE_PROJECT_Celix_INCLUDE"] =
os.path.join(self.build_folder, "conan_paths.cmake")
+ if self.options.enable_gcc_analyzer and self.settings.compiler ==
"gcc":
Review Comment:
Yes, `enable_gcc_analyzer` should be kept in `conanfile.py`.
Check [Introducing the concept of Package
ID](https://docs.conan.io/2/tutorial/consuming_packages/different_configurations.html#introducing-the-concept-of-package-id).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
