----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ -----------------------------------------------------------
(Updated April 16, 2013, 2:53 a.m.) Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, and Min Chen. Changes ------- Please find the latest diff attached with the following changes: - Marvin client API changes to support POST requests by clients - Inclusion of unittest files missing from earlier patch (UserVmDaoTestConfiguration.java and UserVMDaoTestContext.xml) - Fixed a bug discovered during testing w.r.t httpmethod value being populated in the parameter map in the integration port code path The marvin HTTP API itself is still to be put in. I'm working on it, will put it in at the earliest. Tests already exist for DeployVirtualMachineCmd. I will need to make appropriate changes to add to those tests, a case where userdata > 2K is fired using a POST request. Description ------- Please refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements for a background on the requirements driving this patch. This patch hasn't been extensively tested yet, and I will update this request with more info. I am uploading a first diff for initial review/comments. This addresses bug CLOUDSTACK-1086. Diffs (updated) ----- api/src/com/cloud/vm/UserVmService.java d963b74 api/src/org/apache/cloudstack/api/BaseCmd.java 42c0680 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 77ba9fe core/src/com/cloud/vm/UserVmVO.java a16eaf9 server/src/com/cloud/api/ApiDispatcher.java 925d90a server/src/com/cloud/api/ApiServer.java d842819 server/src/com/cloud/api/ApiServerService.java 12d8b52 server/src/com/cloud/api/ApiServlet.java 03bfb5f server/src/com/cloud/vm/UserVmManagerImpl.java d281e5b server/test/com/cloud/vm/MockUserVmManagerImpl.java fd826d9 server/test/com/cloud/vm/dao/UserVmDaoImplTest.java 0936180 server/test/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREATION server/test/resources/UserVMDaoTestContext.xml PRE-CREATION setup/db/db/schema-410to420.sql fb760bf tools/marvin/marvin/cloudstackConnection.py 1caeef3 Diff: https://reviews.apache.org/r/10294/diff/ Testing ------- Thanks, Venkata Siva Vijayendra Bhamidipati