----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10548/ -----------------------------------------------------------
(Updated April 16, 2013, 2:26 p.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta. Description ------- CLOUDSTACK-741: Granular Global Parameters Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account). Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope. This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account). Currently submitted the patch for the zone level parameter use.external.dns. Included unit tests and marvin tests. This addresses bug CLOUDSTACK-741. Diffs ----- api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586 api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION server/src/com/cloud/configuration/Config.java e69ea19 server/src/com/cloud/configuration/ConfigurationManager.java d7faf19 server/src/com/cloud/configuration/ConfigurationManagerImpl.java c9ae854 server/src/com/cloud/configuration/ConfigurationParameterScope.java PRE-CREATION server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059 server/src/com/cloud/server/ConfigurationServer.java f441b1f server/src/com/cloud/server/ConfigurationServerImpl.java 852c00b server/src/com/cloud/server/ManagementServerImpl.java 5ed0c92 server/test/com/cloud/vpc/MockConfigurationManagerImpl.java a03e361 test/integration/smoke/test_UpdateCfg.py PRE-CREATION Diff: https://reviews.apache.org/r/10548/diff/ Testing ------- Tested locally - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id - tested the modified parameter to take the updated value at zone level(after updation). Thanks, Harikrishna Patnala
