> On April 16, 2013, 3:12 p.m., Nitin Mehta wrote: > > server/src/com/cloud/configuration/Config.java, line 342 > > <https://reviews.apache.org/r/10548/diff/1/?file=281566#file281566line342> > > > > So this is available only at zone level and not at the global level is > > it ?
By default every parameter is at global, we specify only if there are additional scopes. > On April 16, 2013, 3:12 p.m., Nitin Mehta wrote: > > server/src/com/cloud/configuration/Config.java, line 432 > > <https://reviews.apache.org/r/10548/diff/1/?file=281566#file281566line432> > > > > Do u need this ? Yes, to put back the new list in the map. > On April 16, 2013, 3:12 p.m., Nitin Mehta wrote: > > server/src/com/cloud/configuration/ConfigurationParameterScope.java, line 18 > > <https://reviews.apache.org/r/10548/diff/1/?file=281569#file281569line18> > > > > Can we not add this in Configuration interface itself ? Added in the config file where we create group of parameters at each level using this enum. > On April 16, 2013, 3:12 p.m., Nitin Mehta wrote: > > server/src/com/cloud/server/ConfigurationServerImpl.java, line 689 > > <https://reviews.apache.org/r/10548/diff/1/?file=281573#file281573line689> > > > > I would like to see a clean switch statement here... Currently this patch support zone level parameter, so 'll add switch case when I put other parameters at different levels(cluster/pool/account) - Harikrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10548/#review19248 ----------------------------------------------------------- On April 17, 2013, 11:09 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10548/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 11:09 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin > Mehta. > > > Description > ------- > > CLOUDSTACK-741: Granular Global Parameters > > Modified UpdateConfiguration API and ListConfiguration API by adding > additional parameter scope and resource id (zone/cluster/pool/account). > Scope decides the parameter which level we can update the value and id is the > corresponding id based on the scope. > This scope is defined in the config.java file where we are creating groups > for each level(zone/cluster/pool/account). > Currently submitted the patch for the zone level parameter use.external.dns. > > Included unit tests and marvin tests. > > > This addresses bug CLOUDSTACK-741. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java > aabfd4a > api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java > ffeb586 > api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java > 95b8af2 > api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java > PRE-CREATION > api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java > PRE-CREATION > server/src/com/cloud/configuration/Config.java 2993966 > server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7 > server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > ab91059 > server/src/com/cloud/server/ConfigurationServer.java f441b1f > server/src/com/cloud/server/ConfigurationServerImpl.java 852c00b > server/src/com/cloud/server/ManagementServerImpl.java 98f789a > server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815 > test/integration/smoke/test_UpdateCfg.py PRE-CREATION > > Diff: https://reviews.apache.org/r/10548/diff/ > > > Testing > ------- > > Tested locally > - tested the modified UpdateConfiguration API and ListConfiguration API by > providing the zone scope and zone id > - tested the modified parameter to take the updated value at zone level(after > updation). > > > Thanks, > > Harikrishna Patnala > >
