----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10548/ -----------------------------------------------------------
(Updated April 18, 2013, 8:16 p.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta. Changes ------- updated patch with suggested changes Description ------- CLOUDSTACK-741: Granular Global Parameters Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account). Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope. This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account). Currently submitted the patch for the zone level parameter use.external.dns. Included unit tests and marvin tests. This addresses bug CLOUDSTACK-741. Diffs (updated) ----- api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586 api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2 api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670 server/src/com/cloud/configuration/Config.java 2993966 server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7 server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059 server/src/com/cloud/server/ConfigurationServer.java f441b1f server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab server/src/com/cloud/server/ManagementServerImpl.java 98f789a server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815 test/integration/smoke/test_UpdateCfg.py PRE-CREATION Diff: https://reviews.apache.org/r/10548/diff/ Testing ------- Tested locally - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id - tested the modified parameter to take the updated value at zone level(after updation). Thanks, Harikrishna Patnala