----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ -----------------------------------------------------------
(Updated April 17, 2013, 5:44 a.m.) Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, and Min Chen. Changes ------- Incorporating changes suggested by Prasanna. Have tested the code for both GET and POST HTTP calls. GET fails as expected when > 2K of userdata is provided, and succeeds when less than 2K is passed in. POST succeeds when upto 32K of userdata is supplied and fails if the userdata decoded size exceeds 32K. Random userdata was generated using userdata = b'%s'%(os.urandom(x*1024)) where x is the desired number of KB. I'm having a few issues with marvin in my development environment, and am working on putting in the marvin test. The standalone test scripts worked, it's just a matter of getting the marvin test in place. Description ------- Please refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements for a background on the requirements driving this patch. This patch hasn't been extensively tested yet, and I will update this request with more info. I am uploading a first diff for initial review/comments. This addresses bug CLOUDSTACK-1086. Diffs (updated) ----- api/src/com/cloud/vm/UserVmService.java d963b74 api/src/org/apache/cloudstack/api/BaseCmd.java 42c0680 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 77ba9fe core/src/com/cloud/vm/UserVmVO.java a16eaf9 server/src/com/cloud/api/ApiDispatcher.java 925d90a server/src/com/cloud/api/ApiServer.java d842819 server/src/com/cloud/api/ApiServerService.java 12d8b52 server/src/com/cloud/api/ApiServlet.java 03bfb5f server/src/com/cloud/vm/UserVmManagerImpl.java 53a57c8 server/test/com/cloud/vm/MockUserVmManagerImpl.java fd826d9 server/test/com/cloud/vm/dao/UserVmDaoImplTest.java 0936180 server/test/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREATION server/test/resources/UserVMDaoTestContext.xml PRE-CREATION setup/db/db/schema-410to420.sql 6a7a72c tools/marvin/marvin/cloudstackConnection.py 1caeef3 Diff: https://reviews.apache.org/r/10294/diff/ Testing ------- Thanks, Venkata Siva Vijayendra Bhamidipati
