----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ -----------------------------------------------------------
(Updated April 23, 2013, 1:49 a.m.) Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, and Min Chen. Changes ------- In this latest patch are fixes for a few issues related to userdata propagation detected during manual testing. I've removed the marvin related changes since Prasanna is making them separately. I have added a marvin test to deploy a VM with user data. However, VirtualMachine.create() isn't written to take POST yet, and it needs to be changed. I did make changes to the framework - but they didn't work as I expected. The VirtualMachine.create() code path uses the python requests package to send out GET/POST requests. Somewhere the post data is not being honoured. Prasanna, if you can take a look, that would be great. At the moment, it doesn't look like marvin supports POST APIs. I will also be uploading the standalone scripts I used to manually test the GET/POST with small/large userdata. I request that writing the marvin test for POST be taken as an action item for now, so that I can complete it once the marvin API issues are addressed, and that this patch be pushed upstream. Description ------- Please refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements for a background on the requirements driving this patch. This patch hasn't been extensively tested yet, and I will update this request with more info. I am uploading a first diff for initial review/comments. This addresses bug CLOUDSTACK-1086. Diffs (updated) ----- api/src/com/cloud/vm/UserVmService.java aa21136 api/src/org/apache/cloudstack/api/BaseCmd.java 42c0680 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 70c0159 api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java ff8fff1 core/src/com/cloud/vm/UserVmVO.java a16eaf9 server/src/com/cloud/api/ApiDispatcher.java 925d90a server/src/com/cloud/api/ApiServer.java d842819 server/src/com/cloud/api/ApiServerService.java 12d8b52 server/src/com/cloud/api/ApiServlet.java 03bfb5f server/src/com/cloud/vm/UserVmManagerImpl.java 1843f60 server/test/com/cloud/vm/MockUserVmManagerImpl.java 0d0a8f4 server/test/com/cloud/vm/dao/UserVmDaoImplTest.java 0936180 server/test/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREATION server/test/resources/UserVMDaoTestContext.xml PRE-CREATION setup/db/db/schema-410to420.sql 10cdbba test/integration/component/test_deploy_vm_with_userdata.py PRE-CREATION Diff: https://reviews.apache.org/r/10294/diff/ Testing ------- Thanks, Venkata Siva Vijayendra Bhamidipati
