----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12934/#review23920 -----------------------------------------------------------
test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment47766> Missing clean up for account and domain. test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment47767> Missing tearDown() test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment47769> I think we already have alike mechanism for executing inside user VM? Check get_ssh_client. If it doesn't fit, we need some generic mechanism rather than one method for one test case. test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment47771> You need to wait a while (e.g. 60 seconds) for mgmt server complete the updating of RvR status. - Sheng Yang On July 26, 2013, 6:27 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12934/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 6:27 a.m.) > > > Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna > Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Tests for egress firewall rules for advance zone. > > > Diffs > ----- > > test/integration/component/test_egress_fw_rules.py PRE-CREATION > > Diff: https://reviews.apache.org/r/12934/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > >
