----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12934/#review24517 -----------------------------------------------------------
test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment48526> I appreciate your effort in correcting the test cases. There are few comments from my side. Please fix those. Also the script is failed to run.Also look into this. The below exception is thrown integration.component.test_egress_fw_rules.log_test_exceptions ... ERROR ====================================================================== ERROR: integration.component.test_egress_fw_rules.log_test_exceptions ---------------------------------------------------------------------- Traceback (most recent call last): File "/Library/Python/2.7/site-packages/nose/case.py", line 197, in runTest self.test(*self.arg) TypeError: log_test_exceptions() takes exactly 1 argument (0 given) test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment48519> change the comment. Egress policy is true test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment48520> fix the comment. access to public network for tcp port 80 is blocked. test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment48521> Egress policy is not set to false, but comment says false. The above test case is already set to true test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment48522> Fix the comment, invalid cidr is passed to create the rule test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment48523> Invalid cidr is not passed to rule. fix the comment test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment48524> Fix the comment test/integration/component/test_egress_fw_rules.py <https://reviews.apache.org/r/12934/#comment48525> Fix the comment - Jayapal Reddy On Aug. 1, 2013, 6:19 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12934/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 6:19 a.m.) > > > Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna > Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Tests for egress firewall rules for advance zone. > > > Diffs > ----- > > test/integration/component/test_egress_fw_rules.py PRE-CREATION > > Diff: https://reviews.apache.org/r/12934/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > >
