----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/#review27372 -----------------------------------------------------------
test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53228> why a new Services() instance when you can use the attribute from the class? self.services["vlan"]? test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53229> can we give this a better name? The naming of the tests should be improved. test_01/02/03 doesn't tell much about the test. Also is the ordering strictly required? Can I reorder the tests and still expect the tests to pass? If not, we should remove the 01 , 02 , 03 in the tests. - Prasanna Santhanam On Oct. 23, 2013, 9:01 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14319/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 9:01 a.m.) > > > Review request for cloudstack, bharat kumar and sanjeev n. > > > Repository: cloudstack-git > > > Description > ------- > > Adding Automation test cases for feature - Non Contiguous VLAN ranges > CLOUDSTACk 2238. > > > Diffs > ----- > > test/integration/component/test_non_contiguous_vlan.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14319/diff/ > > > Testing > ------- > > Tested locally on XenServer Setup > > Log: > > test_01 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_02 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_03 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_04 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_05 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > > ---------------------------------------------------------------------- > Ran 5 tests in 22.387s > > OK > > > Thanks, > > Gaurav Aradhye > >
