----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/#review27377 -----------------------------------------------------------
test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53233> test_add_non_contiguous_ranges test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53234> test_add_existing_vlan_range test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53235> test_extend_contiguous_range test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53236> test_remove_unused_range test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53237> test_remove_used_range I've given names I think are appropriate for the tests. Let me know if they make sense to you. In such cases the @docstring should include a more complete gist of what the test is doing. I'm aware of the account limit. At least we hit that limitation in a test. AFAIK, we don't have tests for these boundary limits for db columns. I remember it failed with an embarrassing looking stacktrace. However, I don't recall if the API failed gracefully or not. - Prasanna Santhanam On Oct. 23, 2013, 9:01 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14319/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 9:01 a.m.) > > > Review request for cloudstack, bharat kumar and sanjeev n. > > > Repository: cloudstack-git > > > Description > ------- > > Adding Automation test cases for feature - Non Contiguous VLAN ranges > CLOUDSTACk 2238. > > > Diffs > ----- > > test/integration/component/test_non_contiguous_vlan.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14319/diff/ > > > Testing > ------- > > Tested locally on XenServer Setup > > Log: > > test_01 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_02 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_03 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_04 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_05 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > > ---------------------------------------------------------------------- > Ran 5 tests in 22.387s > > OK > > > Thanks, > > Gaurav Aradhye > >
