On Oct. 23, 2013, 9:08 a.m., Gaurav Aradhye wrote: > > The naming of the tests should be improved. test_01/02/03 doesn't tell much > > about the test. Also is the ordering strictly required? Can I reorder the > > tests and still expect the tests to pass? If not, we should remove the 01 , > > 02 , 03 in the tests. > > Gaurav Aradhye wrote: > Yes the tests can be reordered and run successfully. I will change the > test names. The only reason to keep such test names was to avoid long test > names which tell the same thing which is written in the comments (Steps and > validation steps), 01,02,03 does not stand for any ordering. > > Prasanna Santhanam wrote: > A meaningful name still makes sense for the tests as the Marvin > TestRunner shows the first line in your docstring and if that's not available > the name of the test itself which will look like test_01. The report is > easier to understand with names. That's my only complaint.
The problem with earlier test naming was that neither the name could indicate purpose of the test, given its complexity nor name was concise enough to be called out. With new names it is at least easy to refer tests "non_contiguous_vlan test_03" instead of some test_name_too_long_to_use_but_to_short_to_describe_test. And the tests will have the description of what it does. Secondly, we use testname to construct account name and the db cannot handle account name more that 100 chars. I have seen at least one such defect. The numbering does not indicate sequential order for execution. - Girish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/#review27372 ----------------------------------------------------------- On Oct. 23, 2013, 9:01 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14319/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 9:01 a.m.) > > > Review request for cloudstack, bharat kumar and sanjeev n. > > > Repository: cloudstack-git > > > Description > ------- > > Adding Automation test cases for feature - Non Contiguous VLAN ranges > CLOUDSTACk 2238. > > > Diffs > ----- > > test/integration/component/test_non_contiguous_vlan.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14319/diff/ > > > Testing > ------- > > Tested locally on XenServer Setup > > Log: > > test_01 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_02 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_03 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_04 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_05 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > > ---------------------------------------------------------------------- > Ran 5 tests in 22.387s > > OK > > > Thanks, > > Gaurav Aradhye > >
