Looks good to me. Applied to MASTER branch. Thanks!
--Sheng On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens <wstev...@cloudops.com> wrote: > @Sheng: This should be ready to go now. I built the patch from tonight's > master and I included a more detailed commit message as you requested. Let > me know if you have any questions/problems... > > @David: As per this discussion (and a previous one [1]), I have moved this > code from being built with the depreciated 'nonoss' flag to core since it > does not depend on any 3rd party libraries at build or runtime. > > Cheers, > > Will > > [1] > > http://markmail.org/message/fxphjkba7bonlesd?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto > > > On Tue, Nov 5, 2013 at 11:42 AM, Will Stevens <wstev...@cloudops.com> > wrote: > > > Thanks for that David. You are absolutely correct, this plugin has no > > dependencies on any 3rd party code at build or runtime. Everything the > > plugin requires is built into the plugin. I was unclear if its > dependance > > on a 3rd party API and appliance to be functional was relevant. > > > > I think you are right. I think it should probably be in the core build. > > I will make that change when I merge in the latest master for Sheng and > > rebuild the patch. > > > > Thanks, > > > > Will > > > > > > On Tue, Nov 5, 2013 at 10:19 AM, David Nalley <da...@gnsa.us> wrote: > > > >> So perhaps a bit of history. > >> > >> nonoss/noredist is for targets that aren't built 'by default' (e.g. > >> you must explicitly turn them on). We do this because the ASF wants > >> the default build to be truly unencumbered and where there are > >> dependencies on non-open source, or non-Apache compatible code, we > >> typically turn them off. In example: historically, Netscaler libraries > >> were not open source, and we had a dependency on those libraries, so > >> we placed the netscaler plugin into the nonoss. Since then the > >> netscaler libraries have been open sourced, and we could move those > >> out of noredist. > >> > >> So - is there third party code that you have as a build or runtime > >> dependency? If so what is the license for that third party code? (My > >> really fast perusal didn't catch anything that was immediately > >> troubling) > >> > >> --David > >> > >> On Tue, Nov 5, 2013 at 7:08 AM, Will Stevens <wstev...@cloudops.com> > >> wrote: > >> > Its dependence on a third party API and appliance, similar to the srx > >> and > >> > netscaler. I am not convinced it should be in noredist, but I was > >> following > >> > the same model as other similar plugins. Feedback on this would be > >> > helpful. > >> > > >> > Ws > >> > > >> > On Tuesday, November 5, 2013, David Nalley wrote: > >> > > >> >> On Mon, Nov 4, 2013 at 7:32 PM, Will Stevens <wstev...@cloudops.com > >> <javascript:;>> > >> >> wrote: > >> >> > Sheng, I will rebuild the patch for the latest master. The latest > >> master > >> >> > has depreciated the 'nonoss' flag in favour of 'noredist'. I was > >> building > >> >> > in nonoss previously. I am guessing I should use the noredist flag > >> now? > >> >> > > >> >> > >> >> Will - what is causing this to be noredist/nonoss? My quick perusal > of > >> >> your patch didn't surface anything that would push it into that > >> >> category. > >> >> > >> >> --David > >> >> > >> > > > > >
