+1 on GUI-side sorting (ideally it would be nice if we could sort by clicking a column header in a table...maybe some reasonable column header would be selected by default for each table)
On Thursday, December 18, 2014, Gabor Apati-Nagy < [email protected]> wrote: > My point here is: unless the API supported sorting as a parameter, we > should not rely on any expected sorting done by the API. It is really the > presentation layer's job to show the results in an order it wants to. So > instead of changing the API, I would suggest let's just sort it at UI side. > > I see why sorting by name would be good in some cases, but if the same > names exist in different domains it could easily become confusing. Or it > can be even more confusing if someone tries to find something by hierarchy > - not knowing it's exact name, but knowing where it should be. > > As a future feature, there could be a "browse domains" or similar selector > where a popup could show them in a searchable grid or similar where users > could search by name for instance. > > So I am +1 for sorting at UI side and -1 for changing to "Name (Path)" > format. And +1 for having the same format everywhere. > > Thanks, > Gabor > > > -----Original Message----- > From: Remi Bergsma [mailto:[email protected] <javascript:;>] > Sent: 18 December 2014 12:16 > To: [email protected] <javascript:;> > Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI > > Hi, > > The reason I’ve put the name upfront is because it allows for easy > navigation using a keyboard. But I see your point. > > About the format, it is not consistent now, as most lists display the path > whereas others display just the name (which is really not what you want). > For example when dedicating a zone to an account. I'd suggest changing then > all to the same format. > > As an alternative, would sorting it at the API level be better? Then we > wouldn’t have to do it client side and we’d only have to change it at one > place only. > > Regards, > Remi > > > On Dec 18, 2014, at 12:46 PM, Andrija Panic <[email protected] > <javascript:;>> wrote: > > > +1 for sorting - somwhat painfull to find domains in current situation... > > > > On 18 December 2014 at 11:35, Gabor Apati-Nagy > > <[email protected] <javascript:;>> > > wrote: > >> > >> Hi, > >> > >> I think sorting would be good to have, but I would not change the > >> display format because that would remove hierarchy (as a sorting > criteria). > >> > >> Wouldn't it be good to sort just by path? (To me sorting looks like > >> an improvement, changing the format is more like a change that may > >> cause problem for some.) > >> > >> Cheers, > >> Gabor > >> > >> > >> -----Original Message----- > >> From: Remi Bergsma [mailto:[email protected] <javascript:;>] > >> Sent: 18 December 2014 08:40 > >> To: [email protected] <javascript:;> > >> Subject: CLOUDSTACK-6543 Sorting the domain list in UI > >> > >> Hi all, > >> > >> In our employee cloud most of our employees have their own Domain to > >> spin up machines. Since we have 150+ domains and the lists are > >> unsorted, it is very hard to find the one you need. The order > >> returned by the API is the order they were added. > >> > >> Without any knowledge of the CloudStack UI, I decided to spend some > >> spare time on this, to figure out a way of fixing this issue. I > >> succeeded, as in my dev environment it now shows alphabetically > >> ordered lists. Although, I discovered that the javascript code that > >> does the select for the domains is on many places in the code base (25+ > occurrences, with 3 or so variations). > >> Am I supposed to fix this "ordering" on all these occurrences or am I > >> missing something? > >> > >> First, I fixed it on the most obvious parts that bother us most: > >> > >> https://github.com/remibergsma/cloudstack/commit/af3a7755a26e13d36a36 > >> 00f16acac61085a1fa50 > >> This I have verified works well. > >> > >> Then did a search and altered the others as well: > >> > >> https://github.com/remibergsma/cloudstack/commit/f0a2e09df4b9887d7712 > >> 50dc8682739b8728952b > >> This I still need to test/verify. > >> > >> Before I proceed, could you let me know if this is the way to fix it > >> (without refactoring the whole thing into a single shared function). > >> > >> Thanks, > >> Remi > >> > >> > > > > -- > > > > Andrija Panić > > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: [email protected] o: 303.746.7302 Advancing the way the world uses the cloud <http://solidfire.com/solution/overview/?video=play>*™*
