Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/778#issuecomment-140487166
  
    @rafaelweingartner Thanks for the time you spent on this. The commit header 
is indeed better. It now conveys what is being done. If you happen to have to 
change something in the commit again (for other reasons), may I suggest you 
follow what most people do and make the header like this: `CLOUDSTACK-8750: 
changed variable s_logger to logger non-static`
    
    I've posted on the Jira ticket (CLOUDSTACK-8750) a question about why is 
this change being made. After reading the description of the ticket I couldn't 
figure out what is the improvement. Maybe you could shed some light on that?
    Is it just, not having an extra line in each class declaring the logger? Or 
am I missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to