Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761920
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -509,10 +512,11 @@ public boolean applyIps(final Network network, final
List<? extends PublicIpAddr
final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
final NetworkTopology networkTopology =
networkTopologyContext.retrieveNetworkTopology(dcVO);
- return networkTopology.associatePublicIP(network, ipAddress,
routers);
- } else {
- return false;
+ for (final DomainRouterVO domainRouterVO : routers) {
+ result = networkTopology.associatePublicIP(network,
ipAddress, domainRouterVO);
--- End diff --
&= these constructs only return the last result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
