Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761941
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -468,19 +470,23 @@ public boolean applyStaticNats(final Network network,
final List<? extends Stati
return true;
}
- DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
- NetworkTopology networkTopology =
_networkTopologyContext.retrieveNetworkTopology(dcVO);
-
- return networkTopology.applyStaticNats(network, rules, routers);
+ final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
+ final NetworkTopology networkTopology =
_networkTopologyContext.retrieveNetworkTopology(dcVO);
+ boolean result = false;
+ for (final DomainRouterVO domainRouterVO : routers) {
+ result = networkTopology.applyStaticNats(network, rules,
domainRouterVO);
--- End diff --
don't worry, this one is a fix and will go in. do it on monday
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
