Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761947
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -656,20 +660,22 @@ public static String getHAProxyStickinessCapability()
{
@Override
public boolean applyStaticNats(final Network network, final List<?
extends StaticNat> rules) throws ResourceUnavailableException {
+ boolean result = true;
if (canHandle(network, Service.StaticNat)) {
final List<DomainRouterVO> routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug("Virtual router elemnt doesn't need to
apply static nat on the backend; virtual " + "router doesn't exist in the
network " + network.getId());
- return true;
+ return result;
}
final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
final NetworkTopology networkTopology =
networkTopologyContext.retrieveNetworkTopology(dcVO);
- return networkTopology.applyStaticNats(network, rules,
routers);
- } else {
- return true;
+ for (final DomainRouterVO domainRouterVO : routers) {
+ result = networkTopology.applyStaticNats(network, rules,
domainRouterVO);
--- End diff --
&=
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
