Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175609511
@agneya2001 that is exactly what I meant.
I disagree with you, letting this as they are, it is not simple. Why
duplicate code, when we can do better? Especially if we use a good and
descriptive method name.
About the initialization, I also disagree with you, at that point those
values are not used, so they are needed and you do not need to code those lines.
If those attributes are needed somewhere else, they should be used only at
the point in which they are needed.
Please, keep in mind the less the better. We need quality in our code, not
quantity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
