Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175656788 @rafaelweingartner It is only about realistic test data that is being passed to the method tested. You should differentiate between the tested code and the code that is testing. The logic/code that is being tested should have all the characteristics that you are talking about ie any data that is not being used should not be there. But when it comes to writing tests and creating mocks you do it in a more realistic manner without deducing what could be happening inside the method as you only test what the method is supposed to be doing. That makes it error proof in future and that was what i was talking about.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---